layer-farms-find: limit farm portals to desired min level #1308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Portals listed as possible farm portals should be at least the minlevel. This fixes a a crazy corner case I came across: 4 farm-level portals in a cluster, two level 1 portals about 400m east, then another farm-level portal 400m east of the level 1 portals. The current algorithm thinks the 2 level 1 portals are a farm (since 5 farm-level portals are within 500m radius of the level 1 portals) and draws a circle only around the two level 1 portals. Alternatively, this check can be placed in the "getNearbyPortalCount" function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Portals listed as possible farm portals should be at least the minlevel. This fixes a a crazy corner case I came across:
4 farm-level portals in a cluster, two level 1 portals about 400m east, then another farm-level portal 400m east of the level 1 portals.
The current algorithm thinks the 2 level 1 portals are a farm (since 5 farm-level portals are within 500m radius of the level 1 portals) and draws a circle only around the two level 1 portals.
Alternatively, this check can be placed in the "getNearbyPortalCount" function.