use Kaiser with 85% of Nyquist band .. #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prepare to support more sample rate
Signed-off-by: hayati ayguen <[email protected]>
Signed-off-by: hayati ayguen <[email protected]>
…ring with Drok JDS6600 Signal Generator, generating Sine with 0.3V Amplitude, having RX888 at +0dB ATT (Attenuators deactivated) => 14.6 (+1 sign) Bits are used .. value range ~ 78% Signed-off-by: hayati ayguen <[email protected]>
|
i have rebased the ndec-branch on my repo and fixed the conflicts .. and can compile fine. force pushed to my github repo. |
|
hmm, after changing the pull requests target branch from ndec to master .. github looks happy. |
|
Looks good to me. I vote to merge to master. |
|
Please use "Squash and Merge" instead of "Create a Merge Commit" when you merge the PR. |
howard0su
approved these changes
Jan 10, 2021
howard0su
reviewed
Jan 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
looked into the received spectrum with HDSDR, whilst generating the input (single carrier) with a 'cheap' signal/DDS generator.
the results don't look as expected.
i would suggest to generate and test the decimation core in a unittest - as in 'pipeline dsp' #135 , to check if unwanted spurs/carrier are produced by software-error - or not