-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change to use alpine linux, much small base image size. #1
base: alpine
Are you sure you want to change the base?
Conversation
Hi James. Thanks for submitting this! I've been thinking about having an -alpine version for a while but didn't have time to look into Blenders' compatibility with it. I would like it to live in its own branch though, so people have a choice between the Ubuntu and Alpine options. Can you please rebase it and submit again against the "alpine" branch? By the way, the reason I moved the ENV declarations below that RUN line is to take advantage of Docker's image layer cache, since I expect the Blender version to change more often than the Ubuntu dependencies. That way, you can generate Docker Images for multiple Blender versions without re-running apt-get every time. Thanks again! |
Hey made those changes! but not sure, from security point of view, if separating the dependencies from the blender install is ideal. |
Also being way too pedantic can we change |
Ohh and I think the images is missing. Some dependencies, such as python |
Hi James. Based on the diff, I don't think you rebased from the latest version of the alpine branch. Also, I'm not sure what you mean by changing ENV to ARG. Where? And the missing dependencies? In the Ubuntu branch? |
Change to use alpine linux, much small base image size. + Change Maintainer to Label http://stackoverflow.com/a/39767934/1432051 + run through dockfmt https://github.com/jessfraz/dockfmt Split up build so dependencies can be cached. However not sure if this is ideal from a security perspective.
Hi again, Latest Version:You're right, hadn't noticed your changes, have now rebased. 😄
|
Hi James. Thanks for the detailed explanation. This looks great. I'll look into the ENV vs. ARG distinction some more, but I'm pretty sure that the ENV instruction sets the environment variable only for subsequent Dockerfile instructions during build and don't affect a running container. The ARG instruction seems to be intended for Dockerfiles that are required to pass an argument at build time. I just one to suggest one tiny change: According to the documentation (Dockerfile reference), the LABEL instruction expects a key/value pair separated by an equals sign ('='). Can you make that simple change and resubmit? |
Done! |
James, I built an image with your latest PR and I'm not able to run blender in it. I'm guessing this is what you mean by sorting out dependencies. The following output of the loader for missing shared libraries and other problems should be helpful in tracking down missing libraries. Please rebase and resubmit once you get it working. Thanks!
|
add myself as a maintainer