chore(deps): upgrade project dependencies - #10
Conversation
Add uv settings to reduce supply chain exposure and refresh the lockfile with the latest versions allowed by the configured age gate.
WalkthroughProject dependencies updated with newer versions of SQLAlchemy and FastAPI, dev tool versions bumped (mypy and ruff), and a new UV tool configuration section added. Makefile venv target now clears existing environments on creation. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (2)
Makefile (1)
12-12: Use$(VENV)instead of a hardcoded.venvfor consistency.Line 12 works, but reusing the declared variable avoids drift if the environment path changes later.
Proposed small refactor
venv: - uv venv .venv --clear + uv venv $(VENV) --clear🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@Makefile` at line 12, Replace the hardcoded ".venv" with the declared Makefile variable by changing the invocation that currently reads "uv venv .venv --clear" to use "$(VENV)" instead, so the target and any future changes to the VENV variable stay consistent; locate the line containing the "uv venv" invocation in the Makefile and swap the literal path for "$(VENV)".pyproject.toml (1)
24-27: Good hardening defaults; add an explicit emergency override workflow.Line 24-27 improves supply-chain posture, but please document how to bypass
exclude-newerfor urgent CVE patching so response time isn’t blocked.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@pyproject.toml` around lines 24 - 27, Document and implement an emergency override for the [tool.uv] exclude-newer setting: add a short entry to the repo SECURITY or CONTRIBUTING docs that explains how to bypass exclude-newer for urgent CVE patches, and add a CI workflow (e.g., a GitHub Actions workflow named uv-emergency-override) that accepts an authenticated, auditable trigger (branch label or protected workflow_dispatch with required reviewers) and sets an environment flag to disable or shorten exclude-newer at runtime; also update pyproject.toml comments near the exclude-newer setting to reference this emergency process and the workflow name so maintainers know how to invoke it.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@Makefile`:
- Line 12: Replace the hardcoded ".venv" with the declared Makefile variable by
changing the invocation that currently reads "uv venv .venv --clear" to use
"$(VENV)" instead, so the target and any future changes to the VENV variable
stay consistent; locate the line containing the "uv venv" invocation in the
Makefile and swap the literal path for "$(VENV)".
In `@pyproject.toml`:
- Around line 24-27: Document and implement an emergency override for the
[tool.uv] exclude-newer setting: add a short entry to the repo SECURITY or
CONTRIBUTING docs that explains how to bypass exclude-newer for urgent CVE
patches, and add a CI workflow (e.g., a GitHub Actions workflow named
uv-emergency-override) that accepts an authenticated, auditable trigger (branch
label or protected workflow_dispatch with required reviewers) and sets an
environment flag to disable or shorten exclude-newer at runtime; also update
pyproject.toml comments near the exclude-newer setting to reference this
emergency process and the workflow name so maintainers know how to invoke it.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: c2d80770-95ac-4ff1-ba9a-4323628dcc44
⛔ Files ignored due to path filters (1)
uv.lockis excluded by!**/*.lock
📒 Files selected for processing (2)
Makefilepyproject.toml
Summary
sqlalchemyfrom 2.0.46 to 2.0.48fastapi[standard]from 0.128.0 to 0.135.3mypyto >=1.20.0,ruffto >=0.15.9[tool.uv]settings (package = false,exclude-newer = "1 week")Test plan
Summary by CodeRabbit