Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[makefile] Allow buit-in compilation #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

maximeborges
Copy link

Hello,
I haven't done a lot a kernel work, so I'm not sure this is the cleanest way to do that, but here you go.
The README modification should be self-explanatory, but in case, the goal is to be able to build this module in-tree

@ikwzm
Copy link
Owner

ikwzm commented Jun 18, 2021

Thank you for the PR.

However, I don't understand the significance of changing the Makefile. Isn't the drivers/of/ Makefile used when building into drivers/of ?

@maximeborges
Copy link
Author

Since it's used here as a submodule and not adding the source directly to the kernel source, it sounds better to me to include the folder with obj-$(CONFIG_OF_DTBOCFG) += dtbocfg/ instead of the source file directly in drivers/of/Makefile.

Then the modification in the Makefile of dtbocfg makes it compile by default as a module if built out-of-tree, or in-tree if CONFIG_OF_DTBOCFG set to y.

Not sure about the good practice for such things tho, never done that before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants