Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump grpcio to 1.44 to be compatible with protobuf 5 #220

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

thodkatz
Copy link
Collaborator

@thodkatz thodkatz commented Oct 11, 2024

protobuf 5 requires protoc version >= 3.19.0 that requires grpcio >= 1.44

.proto files have been generated with the updates grpcio=1.44

Fixes #219

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 36.53846% with 66 lines in your changes missing coverage. Please review.

Project coverage is 65.50%. Comparing base (7dc4196) to head (e91bd2c).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
tiktorch/proto/inference_pb2.py 35.36% 53 Missing ⚠️
tiktorch/proto/data_store_pb2.py 40.90% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #220      +/-   ##
==========================================
- Coverage   68.45%   65.50%   -2.96%     
==========================================
  Files          40       40              
  Lines        2270     2267       -3     
==========================================
- Hits         1554     1485      -69     
- Misses        716      782      +66     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thodkatz thodkatz merged commit fb680c1 into ilastik:main Oct 11, 2024
4 of 9 checks passed
@thodkatz thodkatz mentioned this pull request Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant