Merge pull request #8062 from michaelchadwick/remove-header-render-mo…

…difiers Remove several component header render modifiers
ilios · Aug 14, 2024 · 05a7253 · 05a7253
2 parents 12edb05 + 0723986
commit 05a7253
Show file tree

Hide file tree

Showing 12 changed files with 15 additions and 29 deletions.
diff --git a/packages/frontend/.lint-todo b/packages/frontend/.lint-todo
@@ -12,8 +12,6 @@ add|ember-template-lint|no-at-ember-render-modifiers|4|4|4|4|23cd787c79c34a628da
 add|ember-template-lint|no-at-ember-render-modifiers|5|2|5|2|23cd787c79c34a628dadb6e96dd4004d42eebb79|1722902400000|1730682000000|1754006400000|app/components/curriculum-inventory/new-report.hbs
 add|ember-template-lint|no-at-ember-render-modifiers|4|2|4|2|23cd787c79c34a628dadb6e96dd4004d42eebb79|1722902400000|1730682000000|1754006400000|app/components/curriculum-inventory/new-sequence-block.hbs
 add|ember-template-lint|no-at-ember-render-modifiers|5|2|5|2|77e3831e4ae1b00caee1f808711f2e26ab452a23|1722902400000|1730682000000|1754006400000|app/components/curriculum-inventory/new-sequence-block.hbs
-add|ember-template-lint|no-at-ember-render-modifiers|3|2|3|2|ec3a02c7de9a846320bb33eb702a742de00e56bd|1722902400000|1730682000000|1754006400000|app/components/curriculum-inventory/report-header.hbs
-add|ember-template-lint|no-at-ember-render-modifiers|4|2|4|2|708f3a1a4359e7d1bd669262535d882c49469947|1722902400000|1730682000000|1754006400000|app/components/curriculum-inventory/report-header.hbs
 add|ember-template-lint|no-at-ember-render-modifiers|3|2|3|2|23cd787c79c34a628dadb6e96dd4004d42eebb79|1722902400000|1730682000000|1754006400000|app/components/curriculum-inventory/report-overview.hbs
 add|ember-template-lint|no-at-ember-render-modifiers|3|2|3|2|23cd787c79c34a628dadb6e96dd4004d42eebb79|1722902400000|1730682000000|1754006400000|app/components/curriculum-inventory/report-rollover.hbs
 add|ember-template-lint|no-at-ember-render-modifiers|4|2|4|2|5e634ade97cc174a33ee6f2fdce6c42465ec31e3|1722902400000|1730682000000|1754006400000|app/components/curriculum-inventory/report-rollover.hbs
@@ -37,16 +35,10 @@ add|ember-template-lint|no-at-ember-render-modifiers|111|6|111|6|b432d5e6ea21f6b
 add|ember-template-lint|no-at-ember-render-modifiers|122|6|122|6|7888b1986f039c99dbc62e306f5d5bc34c90ae39|1722902400000|1730682000000|1754006400000|app/components/curriculum-inventory/verification-preview.hbs
 add|ember-template-lint|no-at-ember-render-modifiers|133|6|133|6|4d6c3374c9f845e60bda3b640ec49a3be3ee6fbb|1722902400000|1730682000000|1754006400000|app/components/curriculum-inventory/verification-preview.hbs
 add|ember-template-lint|no-at-ember-render-modifiers|144|6|144|6|e49fa902e44c371593d62096c490244ec75a9083|1722902400000|1730682000000|1754006400000|app/components/curriculum-inventory/verification-preview.hbs
-add|ember-template-lint|no-at-ember-render-modifiers|4|2|4|2|7312526529ca39ed820819d1478d8e1b8f555279|1722902400000|1730682000000|1754006400000|app/components/instructor-group/header.hbs
-add|ember-template-lint|no-at-ember-render-modifiers|5|2|5|2|10c85f1f7f9cf2d05a7f36c4618679ea04c51154|1722902400000|1730682000000|1754006400000|app/components/instructor-group/header.hbs
-add|ember-template-lint|no-at-ember-render-modifiers|4|2|4|2|7312526529ca39ed820819d1478d8e1b8f555279|1722902400000|1730682000000|1754006400000|app/components/learner-group/header.hbs
-add|ember-template-lint|no-at-ember-render-modifiers|5|2|5|2|c33c821719fcbe918954f20b45e0959a3a40c62b|1722902400000|1730682000000|1754006400000|app/components/learner-group/header.hbs
 add|ember-template-lint|no-at-ember-render-modifiers|3|2|3|2|cb6d7acb9879902b89ad1575846d290a564ffbae|1722902400000|1730682000000|1754006400000|app/components/learner-group/instructor-manager.hbs
 add|ember-template-lint|no-at-ember-render-modifiers|4|2|4|2|2bdc98d02ac5ea2a4bd5bac6a0f9e880abafdcbe|1722902400000|1730682000000|1754006400000|app/components/learner-group/instructor-manager.hbs
 add|ember-template-lint|no-at-ember-render-modifiers|4|4|4|4|170987df2d1e4c134a0ac459fc0bdd8dd91b9929|1722902400000|1730682000000|1754006400000|app/components/learner-group/root.hbs
 add|ember-template-lint|no-at-ember-render-modifiers|5|4|5|4|7c59a55b95fd159dd99afa6b20e5f05b5b68def0|1722902400000|1730682000000|1754006400000|app/components/learner-group/root.hbs
-add|ember-template-lint|no-at-ember-render-modifiers|4|4|4|4|66fe3cf991d61995cda5f5935874230700b5e21f|1722902400000|1730682000000|1754006400000|app/components/program/header.hbs
-add|ember-template-lint|no-at-ember-render-modifiers|5|4|5|4|0bcfaa7865c6a954a5b5226ffe44ddc6c63945ba|1722902400000|1730682000000|1754006400000|app/components/program/header.hbs
 add|ember-template-lint|no-at-ember-render-modifiers|3|2|3|2|66fe3cf991d61995cda5f5935874230700b5e21f|1722902400000|1730682000000|1754006400000|app/components/program/overview.hbs
 add|ember-template-lint|no-at-ember-render-modifiers|4|2|4|2|0bcfaa7865c6a954a5b5226ffe44ddc6c63945ba|1722902400000|1730682000000|1754006400000|app/components/program/overview.hbs
 add|ember-template-lint|no-at-ember-render-modifiers|5|2|5|2|12f77ac1f8c43640397b771ba2c9830dd2041f23|1722902400000|1730682000000|1754006400000|app/components/program-year/collapsed-objectives.hbs

diff --git a/packages/frontend/app/components/curriculum-inventory/report-header.hbs b/packages/frontend/app/components/curriculum-inventory/report-header.hbs
@@ -1,7 +1,5 @@
 <div
   class="curriculum-inventory-report-header"
-  {{did-insert this.load @report}}
-  {{did-update this.load @report}}
   data-test-curriculum-inventory-report-header
   ...attributes
 >

diff --git a/packages/frontend/app/components/curriculum-inventory/report-header.js b/packages/frontend/app/components/curriculum-inventory/report-header.js
@@ -8,9 +8,9 @@ import { restartableTask } from 'ember-concurrency';
 export default class CurriculumInventoryReportHeaderComponent extends Component {
   @NotBlank() @Length(3, 200) @tracked name;
 
-  @action
-  load(element, [report]) {
-    this.name = report?.name;
+  constructor() {
+    super(...arguments);
+    this.name = this.args.report.name;
   }
 
   saveName = restartableTask(async () => {

diff --git a/packages/frontend/app/components/instructor-group/header.hbs b/packages/frontend/app/components/instructor-group/header.hbs
@@ -1,8 +1,6 @@
 <div
   class="instructor-group-header"
   data-test-instructor-group-header
-  {{did-insert this.load}}
-  {{did-update this.load @instructorGroup.title}}
   ...attributes
 >
   {{! template-lint-disable no-bare-strings }}

diff --git a/packages/frontend/app/components/instructor-group/header.js b/packages/frontend/app/components/instructor-group/header.js
@@ -10,8 +10,8 @@ export default class InstructorGroupHeaderComponent extends Component {
   @service store;
   @tracked @NotBlank() @Length(3, 60) title;
 
-  @action
-  load() {
+  constructor() {
+    super(...arguments);
     this.title = this.args.instructorGroup.title;
   }
 

diff --git a/packages/frontend/app/components/learner-group/header.hbs b/packages/frontend/app/components/learner-group/header.hbs
@@ -1,8 +1,6 @@
 <header
   class="learner-group-header"
   data-test-learner-group-header
-  {{did-insert this.load}}
-  {{did-update this.load @learnerGroup}}
   ...attributes
 >
   <div class="header-bar">

diff --git a/packages/frontend/app/components/learner-group/header.js b/packages/frontend/app/components/learner-group/header.js
@@ -9,6 +9,11 @@ import { TrackedAsyncData } from 'ember-async-data';
 export default class LearnerGroupHeaderComponent extends Component {
   @tracked @NotBlank() @Length(3, 60) title;
 
+  constructor() {
+    super(...arguments);
+    this.title = this.args.learnerGroup.title;
+  }
+
   @cached
   get upstreamRelationshipsData() {
     return new TrackedAsyncData(this.resolveUpstreamRelationships(this.args.learnerGroup));
@@ -45,11 +50,6 @@ export default class LearnerGroupHeaderComponent extends Component {
     return { cohort, programYear, program, school };
   }
 
-  @action
-  load() {
-    this.title = this.args.learnerGroup.title;
-  }
-
   @action
   revertTitleChanges() {
     this.title = this.args.learnerGroup.title;

diff --git a/packages/frontend/app/components/program/header.hbs b/packages/frontend/app/components/program/header.hbs
@@ -1,8 +1,6 @@
 {{#let (unique-id) as |id|}}
   <div
     class="program-header"
-    {{did-insert this.load @program}}
-    {{did-update this.load @program}}
     data-test-program-header
     ...attributes
   >

diff --git a/packages/frontend/app/components/program/header.js b/packages/frontend/app/components/program/header.js
@@ -1,15 +1,14 @@
 import Component from '@glimmer/component';
 import { tracked } from '@glimmer/tracking';
-import { action } from '@ember/object';
 import { validatable, Length, NotBlank } from 'ilios-common/decorators/validation';
 import { dropTask } from 'ember-concurrency';
 
 @validatable
 export default class ProgramHeaderComponent extends Component {
   @NotBlank() @Length(3, 200) @tracked title;
 
-  @action
-  load() {
+  constructor() {
+    super(...arguments);
     this.title = this.args.program.title;
   }
 

diff --git a/packages/lti-course-manager/.lint-todo b/packages/lti-course-manager/.lint-todo
@@ -0,0 +1 @@
+
diff --git a/packages/lti-dashboard/.lint-todo b/packages/lti-dashboard/.lint-todo
@@ -0,0 +1 @@
+
diff --git a/packages/test-app/.lint-todo b/packages/test-app/.lint-todo
@@ -0,0 +1 @@
+