Merge pull request #7998 from michaelchadwick/frontend-5609-user-guid…

…e-icon-improvements improve User Guide icon
ilios · Aug 8, 2024 · 151ed26 · 151ed26
2 parents 30f4836 + 42cbd5d
commit 151ed26
Show file tree

Hide file tree

Showing 3 changed files with 34 additions and 21 deletions.
diff --git a/packages/frontend/app/components/user-guide-link.hbs b/packages/frontend/app/components/user-guide-link.hbs
@@ -2,11 +2,13 @@
   <a
     href="https://iliosproject.gitbook.io/ilios-user-guide"
     target="_blank"
+    aria-labelledby="user-guide-link-icon"
     rel="noopener noreferrer"
   >
     <FaIcon
-      @icon="circle-question"
+      @icon="question"
       @title={{t "general.iliosUserGuide"}}
+      id="user-guide-link-icon"
       data-test-user-guide-link-icon
     />
   </a>

diff --git a/packages/frontend/app/styles/components/ilios-header.scss b/packages/frontend/app/styles/components/ilios-header.scss
@@ -37,8 +37,12 @@
       grid-area: user;
     }
     .user-guide-link {
+      display: flex;
       grid-area: guide;
-      height: 100%;
+
+      @include m.for-phone-only {
+        vertical-align: -0.25em;
+      }
     }
 
     .global-search-box {

diff --git a/packages/frontend/app/styles/components/user-guide-link.scss b/packages/frontend/app/styles/components/user-guide-link.scss
@@ -1,30 +1,37 @@
 @use "../ilios-common/mixins" as cm;
 @use "../ilios-common/colors" as c;
 
-.user-guide-link {
-  margin-left: 0.5rem;
+@use "sass:color";
 
-  @include cm.for-tablet-and-up {
-    margin-left: 0.25rem;
-    margin-right: 0.5rem;
-  }
+$header-menu-background-color: color.adjust(c.$slightWhite, $lightness: -3%);
+
+.user-guide-link {
+  margin-right: 0.85rem;
 
   a {
-    svg {
-      align-items: center;
-      color: c.$white;
-      display: flex;
-      height: 30px;
-      width: 30px;
+    @include cm.ilios-link-button;
+    background-color: $header-menu-background-color;
+    border: 1px solid $header-menu-background-color;
+    border-radius: 0.2rem;
+    color: c.$raisinBlack;
+    @include cm.font-size("small");
+    font-weight: normal;
+    margin-left: 0.8rem;
+    padding: 0.25em;
+
+    &:hover,
+    &:focus {
+      background-color: c.$white;
+    }
+
+    @include cm.for-tablet-and-up {
+      display: inline;
+      margin-left: 0.5rem;
     }
-  }
 
-  @include cm.for-phone-only {
-    a {
-      svg {
-        height: 24px;
-        width: 24px;
-      }
+    @include cm.for-phone-only {
+      /* stylelint-disable property-disallowed-list */
+      font-size: 2.75vw;
     }
   }
 }