Skip to content

Commit

Permalink
rm unnecessary calls to Array.slice()
Browse files Browse the repository at this point in the history
  • Loading branch information
stopfstedt committed Mar 22, 2024
1 parent aef584c commit 7b56c88
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions packages/ilios-common/addon/components/leadership-expanded.js
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ export default class LeadershipExpandedComponent extends Component {
if (!this.modelHasDirectors) {
return [];
}
const directors = this.modelDirectors.isResolved ? this.modelDirectors.value.slice() : [];
const directors = this.modelDirectors.isResolved ? this.modelDirectors.value : [];
return [...directors, ...this.directorsToAdd].filter(
(user) => !this.directorsToRemove.includes(user),
);
Expand All @@ -72,7 +72,7 @@ export default class LeadershipExpandedComponent extends Component {
return [];
}
const administrators = this.modelAdministrators.isResolved
? this.modelAdministrators.value.slice()
? this.modelAdministrators.value
: [];
return [...administrators, ...this.administratorsToAdd].filter(
(user) => !this.administratorsToRemove.includes(user),
Expand All @@ -85,7 +85,7 @@ export default class LeadershipExpandedComponent extends Component {
return [];
}
const studentAdvisors = this.modelStudentAdvisors.isResolved
? this.modelStudentAdvisors.value.slice()
? this.modelStudentAdvisors.value
: [];
return [...studentAdvisors, ...this.studentAdvisorsToAdd].filter(
(user) => !this.studentAdvisorsToRemove.includes(user),
Expand Down

0 comments on commit 7b56c88

Please sign in to comment.