Merge pull request #8031 from michaelchadwick/frontend-5001-bold-top-…

…level-lg all top-level learner groups are now bolded, regardless of subgroups
ilios · Aug 5, 2024 · 7dee937 · 7dee937
2 parents 5a01621 + 23782b9
commit 7dee937
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 10 deletions.
diff --git a/...ilios-common/addon-test-support/ilios-common/page-objects/components/learnergroup-tree.js b/...ilios-common/addon-test-support/ilios-common/page-objects/components/learnergroup-tree.js
@@ -14,26 +14,26 @@ const definition = {
   needsAccommodation: isVisible('> [data-icon="universal-access"]'),
   toggle: clickable(' > [data-test-checkbox]'),
   toggleTitle: clickable(' > [data-test-checkbox-title]'),
-  isStyledAsLeaf: hasClass('em'),
-  isStyledAsBranch: hasClass('strong'),
+  isStyledAsLeaf: hasClass('leaf'),
+  isStyledAsBranch: hasClass('branch'),
   isHidden: property('hidden'),
   isChecked: property('checked', '[data-test-checkbox]', { at: 0 }),
   subgroups: collection('> [data-test-subgroups] > [data-test-learnergroup-tree]', {
     title: text('[data-test-checkbox-title]', { at: 0 }),
     needsAccommodation: isVisible(' > [data-icon="universal-access"]'),
     toggle: clickable('[data-test-checkbox]', { at: 0 }),
     toggleTitle: clickable('[data-test-checkbox-title]', { at: 0 }),
-    isStyledAsLeaf: hasClass('em'),
-    isStyledAsBranch: hasClass('strong'),
+    isStyledAsLeaf: hasClass('leaf'),
+    isStyledAsBranch: hasClass('branch'),
     isHidden: property('hidden'),
     isChecked: property('checked', '[data-test-checkbox]', { at: 0 }),
     subgroups: collection('> [data-test-subgroups] > [data-test-learnergroup-tree]', {
       title: text('[data-test-checkbox-title]', { at: 0 }),
       needsAccommodation: isVisible('[data-icon="universal-access"]'),
       toggle: clickable('[data-test-checkbox]', { at: 0 }),
       toggleTitle: clickable('[data-test-checkbox-title]', { at: 0 }),
-      isStyledAsLeaf: hasClass('em'),
-      isStyledAsBranch: hasClass('strong'),
+      isStyledAsLeaf: hasClass('leaf'),
+      isStyledAsBranch: hasClass('branch'),
       isHidden: property('hidden'),
       isChecked: property('checked', '[data-test-checkbox]', { at: 0 }),
     }),

diff --git a/packages/ilios-common/addon/components/learnergroup-tree.hbs b/packages/ilios-common/addon/components/learnergroup-tree.hbs
@@ -1,7 +1,7 @@
 {{#let (unique-id) as |templateId|}}
   <li
     hidden={{this.isHidden}}
-    class="learnergroup-tree {{if this.hasChildren "strong" "em"}}"
+    class="learnergroup-tree {{if this.hasChildren "branch" "leaf"}}"
     data-test-learnergroup-tree
     data-test-learnergroup-tree-root={{if this.isRoot "true" "false"}}
   >

diff --git a/packages/ilios-common/app/styles/ilios-common/mixins/ilios-list.scss b/packages/ilios-common/app/styles/ilios-common/mixins/ilios-list.scss
@@ -164,16 +164,16 @@
     color: c.$raisinBlack;
     margin-left: 20px;
 
-    &.strong {
+    &.branch {
       font-weight: bold;
 
       li {
         font-weight: normal;
       }
     }
 
-    &.em {
-      font-style: italic;
+    &.leaf {
+      font-weight: bold;
 
       li {
         font-style: normal;