Skip to content

Commit

Permalink
Merge pull request #7397 from jrjohnson/node-18
Browse files Browse the repository at this point in the history
Drop node 16
  • Loading branch information
stopfstedt committed Sep 11, 2023
2 parents 431caa4 + 5c88d05 commit 85abd81
Show file tree
Hide file tree
Showing 8 changed files with 15 additions and 19 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ jobs:

strategy:
matrix:
node-version: [16, 18]
node-version: [18]

steps:
- uses: actions/checkout@v4
Expand All @@ -61,7 +61,7 @@ jobs:
timeout-minutes: 10
strategy:
matrix:
node-version: [16, 18]
node-version: [18]
steps:
- uses: actions/checkout@v4
- name: Install Node
Expand Down
5 changes: 2 additions & 3 deletions .github/workflows/coverage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,9 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Use Node.js 16
uses: actions/setup-node@v3
- uses: actions/setup-node@v3
with:
node-version: 16
node-version: 18
cache: 'npm'
- name: install dependencies
run: npm ci
Expand Down
7 changes: 3 additions & 4 deletions .github/workflows/deploy-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,9 @@ jobs:
- uses: actions/checkout@v4
with:
ref: ${{ github.event.pull_request.head.sha }}
- name: Use Node.js 16
uses: actions/setup-node@v3
- uses: actions/setup-node@v3
with:
node-version: 16
node-version: 18
cache: 'npm'
- name: install dependencies
run: npm ci
Expand All @@ -42,4 +41,4 @@ jobs:
owner: context.repo.owner,
repo: context.repo.repo,
body: "Staging build deployed! It can be accessed with `bin/console ilios:update-frontend --staging-build --at-version=pr_preview-${{ github.event.number }}`"
})
})
5 changes: 2 additions & 3 deletions .github/workflows/deploy-production.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,9 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Use Node.js 16
uses: actions/setup-node@v3
- uses: actions/setup-node@v3
with:
node-version: 16
node-version: 18
cache: 'npm'
- name: install dependencies
run: npm ci
Expand Down
5 changes: 2 additions & 3 deletions .github/workflows/deploy-staging.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,9 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Use Node.js 16
uses: actions/setup-node@v3
- uses: actions/setup-node@v3
with:
node-version: 16
node-version: 18
cache: 'npm'
- name: install dependencies
run: npm ci
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/update-transitive-dependencies.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v3
with:
node-version: 16
node-version: 18
- name: remove and re-create lock file
run: |
rm package-lock.json
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
16
18
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -138,8 +138,8 @@
"zxcvbn": "^4.4.2"
},
"engines": {
"node": "16.* || >= 18",
"npm": ">= 8"
"node": ">= 18",
"npm": ">= 9"
},
"ember": {
"edition": "octane"
Expand Down

0 comments on commit 85abd81

Please sign in to comment.