Merge pull request #7364 from stopfstedt/user_search_in_pending_user_…

…updates

fixes user filtering on pending-updates page.

app/controllers/pending-user-updates.js

@@ -3,6 +3,7 @@ import { inject as service } from '@ember/service';
 import { tracked } from '@glimmer/tracking';
 import { task } from 'ember-concurrency';
 import { findById } from 'ilios-common/utils/array-helpers';
+import { isEmpty } from '@ember/utils';
 
 export default class PendingUserUpdatesController extends Controller {
   @service flashMessages;
@@ -41,7 +42,7 @@ export default class PendingUserUpdatesController extends Controller {
     return this.updatesInCurrentSchool.filter((update) => {
       const user = this.store.peekRecord('user', update.belongsTo('user').id());
       const isNotDeleted = !this.deletedUpdates.includes(update);
-      const noUpdateName = !!user.fullName;
+      const noUpdateName = isEmpty(user.fullName);
       const filterMatch = update
         .get('user.fullName')
         .trim()

tests/acceptance/pending-user-updates-test.js

@@ -187,4 +187,39 @@ module('Acceptance | pending user updates', function (hooks) {
     assert.strictEqual(page.updates.length, 0);
     assert.notOk(userModel.enabled);
   });
+
+  test('filter-search users', async function (assert) {
+    const school = this.server.create('school');
+    const user1 = this.server.create('user', {
+      school,
+      enabled: true,
+      firstName: 'lorem',
+      lastName: 'ipsum',
+    });
+    this.server.create('pending-user-update', {
+      user: user1,
+      type: 'missingFromDirectory',
+    });
+    const user2 = this.server.create('user', {
+      school,
+      enabled: true,
+      firstName: 'zig',
+      lastName: 'zag',
+    });
+    this.server.create('pending-user-update', {
+      user: user2,
+      type: 'missingFromDirectory',
+    });
+    await setupAuthentication({ school, administeredSchools: [school] });
+    await page.visit();
+
+    assert.strictEqual(page.updates.length, 2);
+    assert.strictEqual(page.updates[0].userNameInfo.fullName, 'lorem M. ipsum');
+    assert.strictEqual(page.updates[1].userNameInfo.fullName, 'zig M. zag');
+    await page.titleFilter.set('lorem');
+    assert.strictEqual(page.updates.length, 1);
+    assert.strictEqual(page.updates[0].userNameInfo.fullName, 'lorem M. ipsum');
+    await page.titleFilter.set('no match');
+    assert.strictEqual(page.updates.length, 0);
+  });
 });

tests/pages/pending-user-updates.js

@@ -22,6 +22,7 @@ export default create({
   },
   titleFilter: {
     scope: '[data-test-title-filter]',
+    set: fillable('input'),
   },
   updates: collection('[data-test-pending-update]', {
     userNameInfo,