Merge pull request #8045 from jrjohnson/ready-to-merge-label

Replace Approval Based UI Workflow

.github/workflows/required-labels.yml

@@ -0,0 +1,25 @@
+name: Required Labels
+
+on:
+  pull_request:
+    types: [labeled, unlabeled, opened, edited, synchronize]
+jobs:
+  enforce--ready-label:
+    runs-on: ubuntu-latest
+    steps:
+    - uses: mheap/github-action-required-labels@v5
+      with:
+        mode: exactly
+        count: 1
+        labels: |
+          ready to merge
+        message: "Add the 'ready to merge' label to merge this PR"
+  prevent-donotmerge-label:
+    runs-on: ubuntu-latest
+    steps:
+    - uses: mheap/github-action-required-labels@v5
+      with:
+        mode: exactly
+        count: 0
+        labels: "DO NOT MERGE"
+        message: "DO NOT MERGE label is not allowed on this PR"

.github/workflows/ui.yml

@@ -2,9 +2,7 @@ name: User Interface Tests
 
 on:
   pull_request:
-    types: [labeled, ready_for_review, synchronize]
-  pull_request_review:
-    types: [submitted]
+    types: [labeled, opened, synchronize]
 
 concurrency:
   group: ui-${{ github.head_ref || github.ref }}
@@ -15,29 +13,11 @@ env:
   COVERAGE: false
 
 jobs:
-  checkReviews:
-    runs-on: ubuntu-latest
-    outputs:
-      reviewState: ${{ steps.reviews.outputs.reviewState }}
-    if: github.event.pull_request.draft == false
-    steps:
-      - id: reviews
-        run: |
-          reviewState=$(gh pr view  ${{ github.event.pull_request.number }} \
-              --repo ${{ github.repository }} \
-              --json reviewDecision \
-              --jq '.reviewDecision')
-          echo "reviewState=$reviewState" >> "$GITHUB_OUTPUT"
-        env:
-          GH_TOKEN: ${{ github.token }}
   browserstack-test:
     name: Browser Stack Test
     runs-on: ubuntu-latest
     timeout-minutes: 120
-    needs: [checkReviews]
-    if: |
-      github.event.pull_request.draft == false &&
-      needs.checkReviews.outputs.reviewState == 'APPROVED'
+    if: contains(github.event.pull_request.labels.*.name, 'ready to merge')
     strategy:
       fail-fast: false
       max-parallel: 1
@@ -78,10 +58,7 @@ jobs:
     name: Firefox Tests
     runs-on: ubuntu-latest
     timeout-minutes: 20
-    needs: [checkReviews]
-    if: |
-      github.event.pull_request.draft == false &&
-      needs.checkReviews.outputs.reviewState == 'APPROVED'
+    if: contains(github.event.pull_request.labels.*.name, 'ready to merge')
     strategy:
       fail-fast: false
       matrix:
@@ -118,11 +95,9 @@ jobs:
   percy:
     name: Test and Capture Screenshots
     runs-on: ubuntu-latest
-    needs: [firefox-test, browserstack-test, checkReviews]
+    needs: [firefox-test, browserstack-test]
     timeout-minutes: 20
-    if: |
-      github.event.pull_request.draft == false &&
-      needs.checkReviews.outputs.reviewState == 'APPROVED'
+    if: contains(github.event.pull_request.labels.*.name, 'ready to merge')
     strategy:
       fail-fast: false
       matrix:
@@ -143,4 +118,3 @@ jobs:
         run: pnpm --filter ${{ matrix.workspace }} exec percy exec -- ember test
         env:
           PERCY_TOKEN: ${{ vars.PERCY_TOKEN }}
-          PERCY_PULL_REQUEST: ${{ github.event.pull_request.number }}

.github/workflows/update-transitive-dependencies.yaml

@@ -38,6 +38,11 @@ jobs:
             [1]: https://github.com/peter-evans/create-pull-request
           branch: auto-update-dependencies
           labels: dependencies,run percy tests
+      - name: Add Ready Label
+        if: steps.cpr.outputs.pull-request-operation == 'created'
+        run: gh pr edit --add-label "ready to merge" ${{ steps.cpr.outputs.pull-request-number }}
+        env:
+          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
       - name: Approve Pull Request
         if: steps.cpr.outputs.pull-request-operation == 'created'
         run: gh pr review --approve -b "Auto Approved" ${{ steps.cpr.outputs.pull-request-number }}