Merge pull request #8061 from michaelchadwick/frontend-5633-lg-member…

…_subs-style-remove-padding reduce padding on LG members/subgroups when none have been added
ilios · Aug 23, 2024 · ff25fbc · ff25fbc
2 parents 0db0f94 + 9c77536
commit ff25fbc
Show file tree

Hide file tree

Showing 6 changed files with 19 additions and 6 deletions.
diff --git a/packages/frontend/app/components/learner-group/members.hbs b/packages/frontend/app/components/learner-group/members.hbs
@@ -1,6 +1,6 @@
 {{#let (unique-id) as |templateId|}}
   <div
-    class="learner-group-members"
+    class="learner-group-members{{if (eq this.usersInGroup.length 0) " empty"}}"
     data-test-learner-group-members
   >
     {{#if this.usersInGroup.length}}

diff --git a/packages/frontend/app/components/learner-group/root.hbs b/packages/frontend/app/components/learner-group/root.hbs
@@ -241,7 +241,7 @@
               </div>
             {{/if}}
           </div>
-          <div class="list">
+          <div class="list{{if (eq @learnerGroup.childrenCount 0) " empty"}}">
            {{#if @learnerGroup.childrenCount}}
               <LearnerGroup::List
                 @learnerGroups={{this.learnerGroups}}

diff --git a/packages/frontend/app/styles/components/courses/list.scss b/packages/frontend/app/styles/components/courses/list.scss
@@ -1,9 +1,11 @@
 @use "../../mixins" as m;
 
 .courses-list {
-  @include m.main-list-box-table;
-
   i {
     margin-left: 0.5rem;
   }
+
+  .list {
+    @include m.main-list-box-table;
+  }
 }
diff --git a/packages/frontend/app/styles/components/programs/list.scss b/packages/frontend/app/styles/components/programs/list.scss
@@ -1,5 +1,7 @@
 @use "../../mixins" as m;
 
-.list {
-  @include m.main-list-box-table;
+.programs-root {
+  .list {
+    @include m.main-list-box-table;
+  }
 }
diff --git a/packages/frontend/app/styles/mixins/main-list.scss b/packages/frontend/app/styles/mixins/main-list.scss
@@ -95,6 +95,10 @@
   display: block;
   padding: 1rem;
 
+  &.empty {
+    padding: 0;
+  }
+
   table {
     @include cm.ilios-table-structure;
     @include cm.ilios-table-colors;

diff --git a/packages/ilios-common/app/styles/ilios-common/mixins/detail-container.scss b/packages/ilios-common/app/styles/ilios-common/mixins/detail-container.scss
@@ -8,6 +8,11 @@
   margin: 0;
   min-height: 2rem;
   padding: 1rem 0;
+
+  &.empty {
+    min-height: auto;
+    padding-bottom: 0;
+  }
 }
 
 @mixin detail-container-title-style() {