Go back to a resource-based loading approach. #7728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stopfstedt
force-pushed
the
5337_leadership_management
branch
from
684094a
to
52054fc
Compare
moving the resetting the buffers up in the saving process eliminates the flash-of-content that occurred in previous iterations of this component.
this realigns this component with Program::LeadershipExpanded.
replace the modifier-based data loading process with a tracked-resource one already used in leadership mngmt components for programs and program-years. align the related testing components as well while at it.
stopfstedt
force-pushed
the
5337_leadership_management
branch
from
52054fc
to
6442f4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moving the resetting the buffers up in the saving process eliminates the flash-of-content that occurred in previous iterations of this component.
converts all leadership management components to this pattern.
fixes ilios/ilios#5337