Learner Groups now use same loading style as Instructor Groups #7857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrjohnson
requested changes
Jun 4, 2024
| {{#each (repeat @count) as |empty|}} | ||
| <tr class="is-loading"> | ||
| <td class="text-left" colspan="2">{{truncate | ||
| (repeat (random 3 10) "ilios rocks") |
| @@ -122,7 +122,7 @@ | |||
| @setSortBy={{@setSortBy}} | |||
| /> | |||
| {{else}} | |||
| <PulseLoader /> | |||
| <LearnerGroups::Loading /> | |||
There was a problem hiding this comment.
This accepts a count of all the learner groups that will eventually show up on the page and has a row for each one. I think you'll need to massage the data loading a bit to get the same info you need here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ilios/ilios#5426
Learner Groups were using the deprecated(?)
<PulseLoader>loading component, but now they are using the same style as Instructor Groups (i.e. obfuscated shimmer method).