Declare pnpm in package #7911
Closed
Declare pnpm in package #7911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stopfstedt
approved these changes
Jun 27, 2024
We need to do this in order to work around an issue with dependabot that is using an old pnpm version. The downside is we'll need to keep it up to date. My IDE is telling me this format isn't valid and it needs to be x.y.z format, but let's try it with just the major version and see if that solves our issues as we won't need to keep it up to date this way.
The pnpm installer will take less information, but corepack will not and that seems to be what netlify uses. We'll have keep track of this number and increment it with new releases.
|
Hold off on merge, may be fixed at dependabot |
|
Our dependabot issues seem to have been fixed upstream. Closing in favor of that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to do this in order to work around an issue with dependabot that is using an old pnpm version. The downside is we'll need to keep it up to date. My IDE is telling me this format isn't valid and it needs to be x.y.z format, but let's try it with just the major version and see if that solves our issues as we won't need to keep it up to date this way.