Replace Ember Data Packages #7914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrjohnson
force-pushed
the
ember-data-replace-store
branch
from
54e23fe
to
604fe6b
Compare
stopfstedt
requested changes
Jul 1, 2024
|
I'd love to merge this but the conflicting file - |
Instead pull all the packages we need directly and then build our own store. This store is copied from the one in the existing `ember-data` package.
These transforms used to be proved by `ember-data`, but now we need to import them ourselves.
Ember Data does this slightly differently now, having dropped ember-inflector. We had rules strewn about, I've consolidated into a single initializer.
Fixes issues with pnpm peer dependencies.
This is the new configuration pattern for ember-data. We need the legacy support to be included in our build so we add that here.
Added: @ember-data/request @ember-data/request-utils @ember-data/legacy-compat as we use them in transforms and our store. I'm not sure why it works in embroider without it, but it won't build the classic app.
Our new inflector rules seem to be working now.
stopfstedt
force-pushed
the
ember-data-replace-store
branch
from
e8463fe
to
c9c1774
Compare
@dartajax - merge conflict resolved. pls merge once tests have passed again. |
|
supersedes #7901 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The future of Ember Data is in smaller packages, currently this is done by providing the
ember-datameta package which includes the others as well as configuring a store. I've removed the middle man and relied directly on the individual packages as well as configuring our store to match the default one. Doing things this way resolves issues we've been having with peer dependencies, ember data, mirage, and ember-file upload.Because we're jumping from the meta package forward to this point I also had to clear deprecations for providing transforms and inflector rules as well as configure the build in a new way.
I wasn't able to get around
pnpmissues by installing these packages only in common, I tried all the combinations of dev/dep/peer I could think of, still got errors, instead I needed to install the data packages in each app. I think this is fine, we should get all the updates as a group from dependabot anyway.