Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix visual layer display bug when editing session offering #7915

Conversation

michaelchadwick
Copy link
Contributor

Fixes ilios/ilios#5560

Added a tracked value with an action that gets sent down the component pipe from <CoursesSessions> to <Session-Grid-Offering>. Toggling the pencil icon now uses that action to set the value and update position: sticky or not appropriately.

@michaelchadwick
Copy link
Contributor Author

I realize this is a sizable code change, and I'm not sure the variable names are as conventional as they could be, but the functionality is there.

Copy link
Member

@stopfstedt stopfstedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code reviewed and click-tested. LGTM.

@dartajax dartajax merged commit 58d0227 into ilios:master Jul 1, 2024
27 checks passed
@michaelchadwick michaelchadwick deleted the frontend-5560-session-offering-table-header-fix branch July 2, 2024 15:02
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When editing a session's offering, locked table header causes scrolling visual issues
3 participants