-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added text-wrap mixin so it fixes long URLs in Session->ILMs #7936
added text-wrap mixin so it fixes long URLs in Session->ILMs #7936
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! The tests aren't running right now, but this would still be a perfect things to add some Percy screen shots for. Can you throw a percySnapshot()
into a test where this issue can be shown?
@jrjohnson Whenever I run tests locally, I get the following error per Percy: I have not used Percy either, so what're the steps to fixing this and adding such a thing to a test? |
They'll never run locally, but in any test you can use the |
6b6a325
to
c369d4b
Compare
@jrjohnson Changed one of the titles of the LMs so that it was a long URL like in the issue. There was already a percy screenshot taken of that test, so now it should show up there? |
c369d4b
to
9016ba3
Compare
…ordered some attributes for easier scanning
9016ba3
to
069ac7c
Compare
@jrjohnson or @stopfstedt can you please review the percy changes? Thank you! |
Done, handed off to @dartajax for final review and merge. |
I tested this - looks great - |
Refs ilios/ilios#4308