Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added text-wrap mixin so it fixes long URLs in Session->ILMs #7936

Merged

Conversation

michaelchadwick
Copy link
Contributor

Copy link
Member

@jrjohnson jrjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! The tests aren't running right now, but this would still be a perfect things to add some Percy screen shots for. Can you throw a percySnapshot() into a test where this issue can be shown?

stopfstedt
stopfstedt previously approved these changes Jul 8, 2024
@stopfstedt stopfstedt dismissed their stale review July 8, 2024 16:58

Jon requested changes.

@michaelchadwick
Copy link
Contributor Author

@jrjohnson Whenever I run tests locally, I get the following error per Percy:
Screenshot 2024-07-08 at 1 35 04 PM

I have not used Percy either, so what're the steps to fixing this and adding such a thing to a test?

@jrjohnson
Copy link
Member

They'll never run locally, but in any test you can use the await percySnapshot(assert); to take a screen shot and add it to our library of shots so it will be compared in the future. Once you push to GitHub then the magic will happen.

@michaelchadwick michaelchadwick force-pushed the frontend-4308-fix-ilm-link-display branch from 6b6a325 to c369d4b Compare July 12, 2024 23:45
@michaelchadwick
Copy link
Contributor Author

@jrjohnson Changed one of the titles of the LMs so that it was a long URL like in the issue. There was already a percy screenshot taken of that test, so now it should show up there?

@michaelchadwick michaelchadwick force-pushed the frontend-4308-fix-ilm-link-display branch from 9016ba3 to 069ac7c Compare July 16, 2024 22:37
@stopfstedt stopfstedt requested review from stopfstedt and removed request for stopfstedt July 16, 2024 22:46
@michaelchadwick
Copy link
Contributor Author

@jrjohnson or @stopfstedt can you please review the percy changes? Thank you!

@jrjohnson
Copy link
Member

Done, handed off to @dartajax for final review and merge.

@dartajax
Copy link
Member

I tested this - looks great - gonna merge now

@dartajax dartajax merged commit 0186bdd into ilios:master Jul 17, 2024
36 checks passed
@michaelchadwick michaelchadwick deleted the frontend-4308-fix-ilm-link-display branch July 17, 2024 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants