move course-* components into course directory and ditch the prefix. #7937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stopfstedt
force-pushed
the
course-namespace
branch
2 times, most recently
from
d953f54
to
6252dfe
Compare
stopfstedt
force-pushed
the
course-namespace
branch
2 times, most recently
from
a04e872
to
f475552
Compare
jrjohnson
approved these changes
Jul 8, 2024
| @@ -0,0 +1,16 @@ | |||
| @use "../../mixins" as m; | |||
|
|
|||
| .course-visualizations { | |||
There was a problem hiding this comment.
Is this a new consolidation? I couldn't find the matching file in the list, but make it's buried in deletes from other places?
There was a problem hiding this comment.
yes. was packages/ilios-common/app/styles/ilios-common/components/course-visualizations.scss before.
this should make it clear what namespace these belong to, and what their parent components are.
stopfstedt
force-pushed
the
course-namespace
branch
from
f475552
to
0476d0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
does the same with course visualisation components.