Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds data tables to more course visualizations #7946

Merged
merged 43 commits into from
Aug 22, 2024

Commits on Aug 22, 2024

  1. completely redefines course/vocab viz as bar chart and adds data tabl…

    …e to output.
    
    forcing this data into a donut chart gives an inaccurate representation
    - since vocabs can overlap on assigned offering/ilm time, there is no
    100% and therefore no pie to slice.
    using a horizontal bar chart seems more appropriate.
    stopfstedt committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    00bd5c6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e380cdd View commit details
    Browse the repository at this point in the history
  3. rework stylesheets to center graphs on course viz overview page.

    bunch of things here:
    - for the container element, switch from flex to the more robust grid
      layout, 1 col by default - overridden to 2 cols for the overview page
    - replace the width/height on the simple-chart override from
      viewport units to pixels. this allows us to
    center the graphs, at the expense of fixing their dimensions.
    - adds left-hand margin to viz container styles, content now aligns
      better with breadcrumb.
    stopfstedt committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    8d71cc6 View commit details
    Browse the repository at this point in the history
  4. render session types graph as bar chart in the overview.

    no more surprise switch from donut to bar chart here, wysiwyg.
    stopfstedt committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    fad8a2d View commit details
    Browse the repository at this point in the history
  5. replaces resource with tracked async data.

    pushed data post-processing from the getter into the data loading
    function while at it - prep-work for adding data tables, which need to
    draw from the same source as the graph.
    stopfstedt committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    73a1ca4 View commit details
    Browse the repository at this point in the history
  6. filter out zero mins session types before graphing, and slightly rewo…

    …rk bar labels and tooltips.
    stopfstedt committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    e4274a9 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    9198538 View commit details
    Browse the repository at this point in the history
  8. adds data table to course vocab term viz.

    consolidate data loading while at it, there were way too many moving
    parts involved in this prior.
    stopfstedt committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    506c167 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    070b60d View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    af412e7 View commit details
    Browse the repository at this point in the history
  11. redo tooltip contents and graph bar labels.

    this brings this in line with the labels/tooltips for the course vocab
    vizs, which is the new template.
    stopfstedt committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    bd768d5 View commit details
    Browse the repository at this point in the history
  12. clean-up/simplify filteredData() getter.

    data already comes pre-sorted from the data() getter, no need to sort
    again here.
    stopfstedt committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    24d0dfc View commit details
    Browse the repository at this point in the history
  13. adds data table.

    stopfstedt committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    c8c08ea View commit details
    Browse the repository at this point in the history
  14. fixes regression in click-through handler.

    the given data structure had changed, getting the session type id from
    the correct data point within it.
    stopfstedt committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    0824ac5 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    01a0fa8 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    1212caf View commit details
    Browse the repository at this point in the history
  17. fixate height of charts in course viz.

    standardize on the height of the course/objectives viz across the board.
    stopfstedt committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    1e50e6d View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    ccd8434 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    21c5d8d View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    b5e74aa View commit details
    Browse the repository at this point in the history
  21. adds data table.

    stopfstedt committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    e4e7576 View commit details
    Browse the repository at this point in the history
  22. realigns preview with detail-view of graph.

    bar chart across the board.
    stopfstedt committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    6d59705 View commit details
    Browse the repository at this point in the history
  23. filter out instructors without instructional time.

    we have no way to present them in the graph, so let's not include them
    at all.
    stopfstedt committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    7c5f0ad View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    7949cd7 View commit details
    Browse the repository at this point in the history
  25. Configuration menu
    Copy the full SHA
    bc4f24d View commit details
    Browse the repository at this point in the history
  26. adds data tables to course instructor viz.

    convert course/instructor/session-types graph from donut to the more
    appropriate bar-chart.
    stopfstedt committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    549ea45 View commit details
    Browse the repository at this point in the history
  27. rm kruft.

    stopfstedt committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    0e195a9 View commit details
    Browse the repository at this point in the history
  28. code cleanup and html safety.

    - destructuring code to make it a bit more readable
    - chain methods where possible to reduce cognitive load introduced by
      unnecessary local vars
    - ensure that tooltip content is always html safe
    stopfstedt committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    b7d580c View commit details
    Browse the repository at this point in the history
  29. Configuration menu
    Copy the full SHA
    141fade View commit details
    Browse the repository at this point in the history
  30. Configuration menu
    Copy the full SHA
    18b7164 View commit details
    Browse the repository at this point in the history
  31. adds descriptions to chart segments, update component test coverage w…

    …ith data-table tests, filter out zero-data elements.
    stopfstedt committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    32bff2d View commit details
    Browse the repository at this point in the history
  32. Configuration menu
    Copy the full SHA
    0ea808e View commit details
    Browse the repository at this point in the history
  33. Configuration menu
    Copy the full SHA
    a3c6991 View commit details
    Browse the repository at this point in the history
  34. adds "no data" message to course/session-type viz.

    this required further consolidation of data-loading getters to make the loading state check reliable
     - otherwise the "no data" message will blink in while data is still being loaded.
    i've added a spinner while at it since there's a noticable delay with content rendering.
    stopfstedt committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    b60815a View commit details
    Browse the repository at this point in the history
  35. list linked zero instructional time in datatable.

    we need to distringuish between unlinked target entities, and linked target entities
    without instructional time.
    only show a "no data" message if there's nothing linked at all.
    
    while at it - fix content of flash while data is loading by
    consolidating getters.
    
    adds links to sub-visualizations in the data tables.
    stopfstedt committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    55f6a1c View commit details
    Browse the repository at this point in the history
  36. Configuration menu
    Copy the full SHA
    e1601e3 View commit details
    Browse the repository at this point in the history
  37. Configuration menu
    Copy the full SHA
    61635d9 View commit details
    Browse the repository at this point in the history
  38. Configuration menu
    Copy the full SHA
    596502a View commit details
    Browse the repository at this point in the history
  39. Configuration menu
    Copy the full SHA
    81ccbad View commit details
    Browse the repository at this point in the history
  40. Configuration menu
    Copy the full SHA
    da07656 View commit details
    Browse the repository at this point in the history
  41. Configuration menu
    Copy the full SHA
    4056735 View commit details
    Browse the repository at this point in the history
  42. Configuration menu
    Copy the full SHA
    ade62a5 View commit details
    Browse the repository at this point in the history
  43. fix up acceptance test.

    stopfstedt committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    1af7733 View commit details
    Browse the repository at this point in the history