fixes moveTarget() and clearFocus() actions. #7955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stopfstedt
force-pushed
the
5578_locale_chooser
branch
from
c17bb43
to
d5c392a
Compare
michaelchadwick
requested changes
Jul 10, 2024
stopfstedt
force-pushed
the
5578_locale_chooser
branch
from
d5c392a
to
9e221b2
Compare
navigate to the target element of choice from the element that these actions were invoked on, instead of relying on a tracked parent element for this.
stopfstedt
force-pushed
the
5578_locale_chooser
branch
from
9e221b2
to
5beffa2
Compare
yes. turns out that anyway - now it's ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes ilios/ilios#5578
follow-up item to #7922