Replace Mirage Implementation #7969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrjohnson
force-pushed
the
migrate-ember-mirage
branch
from
389631d
to
7e9df63
Compare
Replace ember-cli-mirage with ember-mirage. This new, much more embroider compatible, addon is the way forward for mirage support.
This isn't needed anymore as ember-mirage doesn't run in development by default.
With ember-mirage we lose a lot of the automagic configuration and detection of our factories and models as well as auto calling the `mirage/config` to setup the server. Instead we can just export all this information in common and import it explicitly into our config in each app.
We now provide the mirage server creation explicitly in our tests so we need to call it from a different place.
I'm not sure why I grabbed the ember data import, but I think relying on the standard is better for us.
This import requires us to be using ember-cli-mirage and we aren't anymore. Plus we were barely using it here and can just as easily check these values ourselves.
jrjohnson
force-pushed
the
migrate-ember-mirage
branch
from
fc0c0d7
to
317e9a5
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace ember-cli-mirage with ember-mirage. This new, much more embroider compatible, addon is the way forward for mirage support.
Last commit is the annoying one as it changes all the import paths.
[EDIT: ST 2024/07/16] for reference: https://github.com/bgantzler/ember-mirage/blob/main/docs/migration.md