Fix Issues with Report Downloads #8067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needed to chunk the term download into parts because when we load a big enough set it exceeds the URL limit. The data was also a bit off, fixed that too.
Fixed the filters to add the all important instructed prefix, and fixed the output to actually be text.
|
basic user testing seems good. not seeing any issues. FYI Let's create a follow-on ticket to expand data in and improve display of downloaded data in particular our terms reports. |
stopfstedt
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both the term and instructor reports had issues with their downloads that made them unusable.
Fixes ilios/ilios#5642