Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize the Instructors for Course Report #8074

Merged
merged 2 commits into from
Aug 19, 2024

Conversation

jrjohnson
Copy link
Member

Because of the joins required this report performed very poorly using the API as the number of sessions and offerings in a course grew. Instead we can use our GraphQL API to get the data we want from the course down and significantly improve the performance.

I didn't DRY this up, we probably need to replace the reporting service for download and re-use the data fetching in the subject components, but that is for another day.

Because of the joins required this report performed very poorly using
the API as the number of sessions and offerings in a course grew.
Instead we can use our GraphQL API to get the data we want from the
course down and significantly improve the performance.

I didn't DRY this up, we probably need to replace the reporting service
for download and re-use the data fetching in the subject components, but
that is for another day.
@jrjohnson jrjohnson marked this pull request as ready for review August 16, 2024 15:29
Co-authored-by: Stefan Topfstedt <[email protected]>
@jrjohnson jrjohnson force-pushed the instructor-report-performance branch from 95c48ba to 3c78e43 Compare August 16, 2024 18:38
@saschaben
Copy link
Member

on netlify 'All Instructors for Session Type XX' still fail to complete. no error thrown in the inspector panel.

@stopfstedt stopfstedt self-requested a review August 16, 2024 21:33
Copy link
Member

@stopfstedt stopfstedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dartajax dartajax merged commit 4c5dbb1 into ilios:master Aug 19, 2024
35 checks passed
@jrjohnson jrjohnson deleted the instructor-report-performance branch August 19, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants