Optimize the Instructors for Course Report #8074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because of the joins required this report performed very poorly using the API as the number of sessions and offerings in a course grew. Instead we can use our GraphQL API to get the data we want from the course down and significantly improve the performance. I didn't DRY this up, we probably need to replace the reporting service for download and re-use the data fetching in the subject components, but that is for another day.
stopfstedt
reviewed
Aug 16, 2024
Co-authored-by: Stefan Topfstedt <[email protected]>
jrjohnson
force-pushed
the
instructor-report-performance
branch
from
95c48ba
to
3c78e43
Compare
|
on netlify 'All Instructors for Session Type XX' still fail to complete. no error thrown in the inspector panel. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of the joins required this report performed very poorly using the API as the number of sessions and offerings in a course grew. Instead we can use our GraphQL API to get the data we want from the course down and significantly improve the performance.
I didn't DRY this up, we probably need to replace the reporting service for download and re-use the data fetching in the subject components, but that is for another day.