Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Cohort Loading #8082

Merged
merged 2 commits into from
Aug 20, 2024
Merged

Conversation

jrjohnson
Copy link
Member

Replacing the buffers that get set when the component is loaded with a
change tracking system. This will ensure we're responsive to changes in
the user.

Fixes ilios/ilios#5653

Replacing the buffers that get set when the component is loaded with a
change tracking system. This will ensure we're responsive to changes in
the user.
In order to avoid a jarring change of schools when cohorts are saved,
due to the re-rendering of the manager, I've moved the school selection
up on level in the component tree so the selection is persistent.
@jrjohnson jrjohnson marked this pull request as ready for review August 19, 2024 23:49
Copy link
Member

@stopfstedt stopfstedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, especially with the new and improved tests.

@dartajax dartajax merged commit fb0e4be into ilios:master Aug 20, 2024
41 of 42 checks passed
@jrjohnson jrjohnson deleted the i5653-cohort-picker-reload branch August 21, 2024 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cohort Picker Retaining Values from Previously Selected User
3 participants