Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Existing LM search results style improved #8173

Merged
merged 5 commits into from
Oct 3, 2024
Merged

Existing LM search results style improved #8173

merged 5 commits into from
Oct 3, 2024

Conversation

michaelchadwick
Copy link
Contributor

Fixes ilios/ilios#5688

Changes:

  • reduced font-size of link: h4->h5
  • fixed padding of description and properties so everything lines up
  • last result loses bottom border cuz it looks better
  • "Final" label now has room

@michaelchadwick michaelchadwick added the run ui tests Run the expensive UI tests label Oct 3, 2024
dartajax
dartajax approved these changes Oct 3, 2024
View reviewed changes
Copy link
Member

@dartajax dartajax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like and approve this.

@dartajax dartajax merged commit 838e0dd into ilios:master Oct 3, 2024
42 checks passed
@michaelchadwick michaelchadwick deleted the frontend-5688-lm-search-formatting-fix branch October 3, 2024 18:35
stopfstedt
stopfstedt reviewed Oct 3, 2024
View reviewed changes
Copy link
Member

@stopfstedt stopfstedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

retroactively approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stopfstedt stopfstedt stopfstedt left review comments

@dartajax dartajax dartajax approved these changes

@jrjohnson jrjohnson Awaiting requested review from jrjohnson jrjohnson is a code owner

Assignees

@dartajax dartajax

Labels
run ui tests Run the expensive UI tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Better Formatting On Searching For Existing Learning Marterials to Add to Session
3 participants
@michaelchadwick @stopfstedt @dartajax