Replace get-errors-for helper #8203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stopfstedt
requested review from
jrjohnson and
michaelchadwick
as code owners
michaelchadwick
approved these changes
Oct 30, 2024
jrjohnson
requested changes
Oct 31, 2024
this will allow us to get rid of the get-errors-for helper.
this ditches the "it responds to changes" testcase, since this would now require rigging up a test fixture that's responsive, like a dummy component. way too much effort - we're already testing validation error state changes in integration tests that utilize the ValidationError component.
stopfstedt
force-pushed
the
replace-get-error-for
branch
from
78bc07a
to
53516af
Compare
jrjohnson
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs ilios/ilios#5371
i couldn't figure out how to salvage this
Resource-based helper, so I'm attempting to side-step the issue by shifting its functionality into theValidationErrorcomponent.this changes the interface of the
ValidationErrorcomponent.from:
to: