-
Notifications
You must be signed in to change notification settings - Fork 27
Add user id to admin user search #8783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add user id to admin user search #8783
Conversation
✅ Deploy Preview for ilios-frontend ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
45063d5 to
0d4233e
Compare
stopfstedt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
dartajax
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works for me - I'll get the tests going - merge tomorrow maybe
|
I'm going to wait on this one and merge it tomorrow after our meeting - just want to make sure there are no issues with appending this information to search. It seems it would be helpful. I know that because I filed the ticket while experiencing confusion around this exact issue. |
|
I am not going to merge this but will keep it open for discussion - assigned to me. This ticket was created with a purpose at hand but this is not the correct solution. I apologize for that. The need does arise for admin users to obtain more information about users during a user search. This occurs when multiple users have the same email address, which has happened. Maybe we need to provide a callout, mouse-over, or other report for these users but the inclusion of the Ilios ID on the same line in the interface has been decided not to be the solution. Keep this open please. |
|
@dartajax I think we decided as a team to go through with this one but only if it gets added as a tooltip instead of inline with the name, so I'll update this to that effect. |
43289a0 to
dfac501
Compare
dartajax
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure about this one but it seems useful although users may wonder what the context of that number popping up is - maybe we should add "Ilios User ID: " to it?
|
Maybe @saschaben might want to check this one out. |
|
I slapped a |
|
This is an incorrect solution: we are pulling the Ilios ID as the tooltip, when we should be pulling the Campus ID (the "02" number). Swap out the data attribute getting called and I think we are back on track. |
|
I am keeping the |
Fixes ilios/ilios#4693
Added[id]to search results for easier reference.Added
campusIdas atitle=attribute to the button so it appears as a tooltip.