Replace text-align-bottom() SASS mixin with equivalent class
#8951
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ilios-frontend ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
michaelchadwick
force-pushed
the
6655-replace-text-align-bottom-sass-mixin
branch
2 times, most recently
from
828d4e3 to
2d558ef
Compare
Contributor
Author
|
Changing it from a mixin to a class has a problem: the Possible fixes:
|
michaelchadwick
force-pushed
the
6655-replace-text-align-bottom-sass-mixin
branch
from
2d558ef to
3f8eb49
Compare
Contributor
Author
|
Chosen path forward: add needed |
michaelchadwick
force-pushed
the
6655-replace-text-align-bottom-sass-mixin
branch
from
3f8eb49 to
208db59
Compare
michaelchadwick
requested review from
jrjohnson and
stopfstedt
as code owners
Contributor
Author
|
After much discussion, figured out that this is too specific to be changed without changing higher-order mixins first, so...it's on hold. |
…here needed in order to maintain application order
michaelchadwick
force-pushed
the
6655-replace-text-align-bottom-sass-mixin
branch
from
208db59 to
dcdb7a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs ilios/ilios#6608
Fixes ilios/ilios#6655