Skip to content

Conversation

@stopfstedt
Copy link
Member

this one isn't used anywhere. the only shortTitle attr on a model that comes up is the one on the program class.

stefan@nichtsnutz: ~/dev/projects/frontend on ungunk[$]
$ grep -r '\.shortTitle' packages --exclude-dir=dist --exclude-dir=node_modules --exclude-dir=tests
packages/frontend/app/components/program/overview.gjs:    this.shortTitle = this.args.program.shortTitle;
packages/frontend/app/components/program/overview.gjs:    if (this.shortTitle !== this.args.program.shortTitle) {
packages/frontend/app/components/program/overview.gjs:      this.args.program.set('shortTitle', this.shortTitle);
packages/frontend/app/components/program/overview.gjs:      this.shortTitle = this.args.program.shortTitle;
packages/frontend/app/components/program/overview.gjs:                @value={{this.shortTitle}}
packages/frontend/app/components/program/overview.gjs:                  value={{this.shortTitle}}
packages/frontend/app/components/program/overview.gjs:                @validationErrors={{this.validations.errors.shortTitle}}
packages/frontend/app/components/program/overview.gjs:              {{this.shortTitle}}
packages/frontend/app/components/curriculum-inventory/report-overview.gjs:              {{#if @report.program.shortTitle}}
packages/frontend/app/components/curriculum-inventory/report-overview.gjs:                ({{@report.program.shortTitle}})

@netlify
Copy link

netlify bot commented Dec 3, 2025

Deploy Preview for ilios-frontend ready!

Name Link
🔨 Latest commit 44a36e4
🔍 Latest deploy log https://app.netlify.com/projects/ilios-frontend/deploys/6930cba175c91f0008d93bf2
😎 Deploy Preview https://deploy-preview-8993--ilios-frontend.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@stopfstedt stopfstedt marked this pull request as ready for review December 8, 2025 23:12
@michaelchadwick michaelchadwick added the run ui tests Run the expensive UI tests label Dec 10, 2025
Copy link
Member

@dartajax dartajax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested on program short title for what that's worth - seems fine to me

@dartajax
Copy link
Member

Visual Diff stuff looks fine to me = this PR is ready to be merged as far as I can tell.

@dartajax dartajax merged commit 9c14ae7 into ilios:master Dec 10, 2025
46 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run ui tests Run the expensive UI tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants