Replace font-size($step) SASS mixin with equivalent CSS classes
#8997
+311
−344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ilios-frontend ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
michaelchadwick
force-pushed
the
6710-replace-font-size-sass-mixin
branch
from
f771fe7 to
0437cb5
Compare
Contributor
Author
|
The mixin has been extinguished, but the second-to-last commit, uh, commits a grievous error: simply adding the new shared class's attributes to a bunch of deeply-nested places that I couldn't yet figure out how to untangle. |
michaelchadwick
force-pushed
the
6710-replace-font-size-sass-mixin
branch
from
fe04e7a to
9a386ed
Compare
…ke a couple exceptions in shared font-size file, however
…ded class to main component
…ppropriate font-size-x class where it was used
…mixins, as well as some other various places
…ease at best, and inconsistent font-size with the year picker next to it at worst
… TODO fix this so it uses the font-size shared class
michaelchadwick
force-pushed
the
6710-replace-font-size-sass-mixin
branch
from
9a386ed to
941140e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs ilios/ilios#6608
Fixes ilios/ilios#6710
This is a biggie, and will be done in several passes:
I'm trying to keep commits generally within those boundaries so my journey can be properly followed along with.