Skip to content

Commit

Permalink
auto-correct PHP code linter errors.
Browse files Browse the repository at this point in the history
  • Loading branch information
@stopfstedt
stopfstedt committed Jun 3, 2024
1 parent aae38d3 commit 2cb096d
Show file tree
Hide file tree
Showing 9 changed files with 288 additions and 285 deletions.
80 changes: 40 additions & 40 deletions ajax.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,9 @@
$id = required_param('id', PARAM_INT); // course id
$action = required_param('action', PARAM_ALPHANUMEXT);

$PAGE->set_url(new moodle_url('/enrol/ilios/ajax.php', array('id'=>$id, 'action'=>$action)));
$PAGE->set_url(new moodle_url('/enrol/ilios/ajax.php', ['id' => $id, 'action' => $action]));

$course = $DB->get_record('course', array('id'=>$id), '*', MUST_EXIST);
$course = $DB->get_record('course', ['id' => $id], '*', MUST_EXIST);
$context = context_course::instance($course->id, MUST_EXIST);

if ($course->id == SITEID) {
Expand All @@ -65,14 +65,14 @@

/** @var enrol_ilios_plugin $enrol */
$enrol = enrol_get_plugin('ilios');
$api_client = $enrol->get_api_client();
$access_token = $enrol->get_api_access_token();
$apiclient = $enrol->get_api_client();
$accesstoken = $enrol->get_api_access_token();

switch ($action) {
case 'getselectschooloptions':
require_capability('moodle/course:enrolconfig', $context);
$schools = $api_client->get($access_token, 'schools', '', array('title' => "ASC"));
$schoolarray = array();
$schools = $apiclient->get($accesstoken, 'schools', '', ['title' => "ASC"]);
$schoolarray = [];
foreach ($schools as $school) {
$schoolarray["$school->id:$school->title"] = $school->title;
}
Expand All @@ -82,12 +82,12 @@
case 'getselectprogramoptions':
require_capability('moodle/course:enrolconfig', $context);
$sid = required_param('filterid', PARAM_INT); // school id
$programs = array();
$programs = $api_client->get($access_token, 'programs', array('school' => $sid), array('title' => "ASC"));
$programarray = array();
$programs = [];
$programs = $apiclient->get($accesstoken, 'programs', ['school' => $sid], ['title' => "ASC"]);
$programarray = [];
foreach ($programs as $program) {
$key = $program->id;
foreach (array('shortTitle', 'title') as $attr) {
foreach (['shortTitle', 'title'] as $attr) {
$key .= ':';
if (property_exists($program, $attr)) {
$key .= $program->$attr;
Expand All @@ -101,24 +101,24 @@
case 'getselectcohortoptions':
require_capability('moodle/course:enrolconfig', $context);
$pid = required_param('filterid', PARAM_INT);
$programyears = $api_client->get(
$access_token,
$programyears = $apiclient->get(
$accesstoken,
'programYears',
array("program" => $pid),
array("startYear" => "ASC")
["program" => $pid],
["startYear" => "ASC"]
);
$programyeararray = array();
$cohortoptions = array();
$programyeararray = [];
$cohortoptions = [];
foreach ($programyears as $progyear) {
$programyeararray[] = $progyear->id;
}

if (!empty($programyeararray)) {
$cohorts = $api_client->get(
$access_token,
$cohorts = $apiclient->get(
$accesstoken,
'cohorts',
array("programYear" => $programyeararray),
array("title" => "ASC")
["programYear" => $programyeararray],
["title" => "ASC"]
);
foreach ($cohorts as $cohort) {
$cohortoptions["$cohort->id:$cohort->title"] = $cohort->title
Expand All @@ -133,13 +133,13 @@
require_capability('moodle/course:enrolconfig', $context);
$cid = required_param('filterid', PARAM_INT); // cohort id
$usertype = optional_param('usertype', 0, PARAM_INT); // learner or instructor
$learnergroups = $api_client->get(
$access_token,
$learnergroups = $apiclient->get(
$accesstoken,
'learnerGroups',
array('cohort' => $cid, 'parent' => 'null'),
array('title'=> "ASC")
['cohort' => $cid, 'parent' => 'null'],
['title' => "ASC"]
);
$grouparray = array();
$grouparray = [];
foreach ($learnergroups as $group) {
$grouparray["$group->id:$group->title"] = $group->title.
' ('. count($group->children) .')';
Expand All @@ -152,25 +152,25 @@
require_capability('moodle/course:enrolconfig', $context);
$gid = required_param('filterid', PARAM_INT); // group id
$usertype = optional_param('usertype', 0, PARAM_INT); // learner or instructor
$subgroupoptions = array();
$subgroups = $api_client->get(
$access_token,
$subgroupoptions = [];
$subgroups = $apiclient->get(
$accesstoken,
'learnerGroups',
array("parent" => $gid),
array("title" => "ASC")
["parent" => $gid],
["title" => "ASC"]
);
foreach ($subgroups as $subgroup) {
$subgroupoptions["$subgroup->id:$subgroup->title"] = $subgroup->title.
' ('. count($subgroup->children) .')';
$subgroupoptions["$subgroup->id:$subgroup->title"] .= ' ('. count($subgroup->users) .')';

if (!empty($subgroup->children)) {
$processchildren = function ($parent) use (&$processchildren,&$subgroupoptions, $api_client, $access_token) {
$subgrps = $api_client->get(
$access_token,
$processchildren = function ($parent) use (&$processchildren, &$subgroupoptions, $apiclient, $accesstoken) {
$subgrps = $apiclient->get(
$accesstoken,
'learnerGroups',
array( 'parent' => $parent->id),
array( 'title' => "ASC")
[ 'parent' => $parent->id],
[ 'title' => "ASC"]
);
foreach ($subgrps as $subgrp) {
$subgroupoptions["$subgrp->id:$parent->title / $subgrp->title"] = $parent->title.' / '.$subgrp->title.
Expand All @@ -191,15 +191,15 @@
case 'getselectinstructorgroupoptions':
require_capability('moodle/course:enrolconfig', $context);
$gid = required_param('filterid', PARAM_INT); // group id
$instructorgroupoptions = array();
$learnergroup = $api_client->get_by_id($access_token, 'learnerGroups', $gid);
$instructorgroupoptions = [];
$learnergroup = $apiclient->get_by_id($accesstoken, 'learnerGroups', $gid);
if (!empty($learnergroup->instructorGroups)) {
$instructorgroups = $api_client->get(
$access_token,
$instructorgroups = $apiclient->get(
$accesstoken,
'instructorGroups',
// array("id" => $learnergroup->instructorGroups),
'',
array("title" => "ASC")
["title" => "ASC"]
);
foreach ($instructorgroups as $instructorgroup) {
$instructorgroupoptions["$instructorgroup->id:$instructorgroup->title"] = $instructorgroup->title.
Expand Down
20 changes: 10 additions & 10 deletions db/access.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -25,26 +25,26 @@

defined('MOODLE_INTERNAL') || die();

$capabilities = array(
$capabilities = [

'enrol/ilios:config' => array(
'enrol/ilios:config' => [

'captype' => 'write',
'contextlevel' => CONTEXT_COURSE,
'archetypes' => array(
'archetypes' => [
'editingteacher' => CAP_ALLOW,
'manager' => CAP_ALLOW,
)
),
],
],

/* This is used only when sync suspends users instead of full unenrolment. */
'enrol/ilios:unenrol' => array(
'enrol/ilios:unenrol' => [

'captype' => 'write',
'contextlevel' => CONTEXT_COURSE,
'archetypes' => array(
'archetypes' => [
'manager' => CAP_ALLOW,
)
),
],
],

);
];
10 changes: 5 additions & 5 deletions db/tasks.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -24,14 +24,14 @@

defined('MOODLE_INTERNAL') || die();

$tasks = array(
array(
$tasks = [
[
'classname' => '\enrol_ilios\task\ilios_sync_task',
'blocking' => 0,
'minute' => '55',
'hour' => '*',
'day' => '*',
'dayofweek' => '*',
'month' => '*'
)
);
'month' => '*',
],
];
4 changes: 2 additions & 2 deletions db/uninstall.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -29,13 +29,13 @@ function xmldb_enrol_ilios_uninstall() {
global $CFG, $DB;

$ilios = enrol_get_plugin('ilios');
$rs = $DB->get_recordset('enrol', array('enrol'=>'ilios'));
$rs = $DB->get_recordset('enrol', ['enrol' => 'ilios']);
foreach ($rs as $instance) {
$ilios->delete_instance($instance);
}
$rs->close();

role_unassign_all(array('component'=>'enrol_ilios'));
role_unassign_all(['component' => 'enrol_ilios']);

return true;
}
40 changes: 20 additions & 20 deletions edit.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -30,17 +30,17 @@
$courseid = required_param('courseid', PARAM_INT);
$instanceid = optional_param('id', 0, PARAM_INT);

$course = $DB->get_record('course', array('id'=>$courseid), '*', MUST_EXIST);
$course = $DB->get_record('course', ['id' => $courseid], '*', MUST_EXIST);
$context = context_course::instance($course->id, MUST_EXIST);

require_login($course);
require_capability('moodle/course:enrolconfig', $context);
require_capability('enrol/ilios:config', $context);

$PAGE->set_url('/enrol/ilios/edit.php', array('courseid'=>$course->id, 'id'=>$instanceid));
$PAGE->set_url('/enrol/ilios/edit.php', ['courseid' => $course->id, 'id' => $instanceid]);
$PAGE->set_pagelayout('admin');

$returnurl = new moodle_url('/enrol/instances.php', array('id'=>$course->id));
$returnurl = new moodle_url('/enrol/instances.php', ['id' => $course->id]);
if (!enrol_is_enabled('ilios')) {
redirect($returnurl);
}
Expand All @@ -49,14 +49,14 @@
$enrol = enrol_get_plugin('ilios');

if ($instanceid) {
$instance = $DB->get_record('enrol', array('courseid'=>$course->id, 'enrol'=>'ilios', 'id'=>$instanceid), '*', MUST_EXIST);
$instance = $DB->get_record('enrol', ['courseid' => $course->id, 'enrol' => 'ilios', 'id' => $instanceid], '*', MUST_EXIST);

} else {
// No instance yet, we have to add new instance.
if (!$enrol->get_newinstance_link($course->id)) {
redirect($returnurl);
}
navigation_node::override_active_url(new moodle_url('/enrol/instances.php', array('id'=>$course->id)));
navigation_node::override_active_url(new moodle_url('/enrol/instances.php', ['id' => $course->id]));
$instance = new stdClass();
$instance->id = null;
$instance->courseid = $course->id;
Expand All @@ -74,7 +74,7 @@
$courseadmin->get('users')->get('manageinstances')->make_active();
}

$mform = new enrol_ilios_edit_form(null, array($instance, $enrol, $course));
$mform = new enrol_ilios_edit_form(null, [$instance, $enrol, $course]);

if ($mform->is_cancelled()) {
redirect($returnurl);
Expand All @@ -83,49 +83,49 @@
// We are here only because the form is submitted.
$synctype = '';
$syncid = '';
$syncinfo = array();
$syncinfo = [];

$selectvalue = isset($data->selectschool) ? $data->selectschool : '';
if (!empty($selectvalue)) {
list($schoolid, $schooltitle) = explode( ":", $selectvalue, 2);
$syncinfo["school"] = array("id" => $schoolid, "title" => $schooltitle);
$syncinfo["school"] = ["id" => $schoolid, "title" => $schooltitle];
}

$selectvalue = isset($data->selectprogram) ? $data->selectprogram : '';
if (!empty($selectvalue)) {
list($programid, $programshorttitle, $programtitle) = explode( ":", $selectvalue, 3);
$syncinfo["program"] = array("id" => $programid, "shorttitle" => $programshorttitle, "title" => $programtitle);
$syncinfo["program"] = ["id" => $programid, "shorttitle" => $programshorttitle, "title" => $programtitle];
}

$selectvalue = isset($data->selectcohort) ? $data->selectcohort : '';
if (!empty($selectvalue)) {
list($cohortid, $cohorttitle) = explode( ":", $selectvalue, 2);
$synctype = 'cohort';
$syncid = $cohortid;
$syncinfo["cohort"] = array("id" => $cohortid, "title" => $cohorttitle);
$syncinfo["cohort"] = ["id" => $cohortid, "title" => $cohorttitle];
}

$selectvalue = isset($data->selectlearnergroup) ? $data->selectlearnergroup : '';
if (!empty($selectvalue)) {
list($learnergroupid, $learnergrouptitle) = explode( ":", $selectvalue, 2);
$synctype = 'learnerGroup';
$syncid = $learnergroupid;
$syncinfo["learnerGroup"] = array( "id" => $learnergroupid, "title" => $learnergrouptitle );
$syncinfo["learnerGroup"] = [ "id" => $learnergroupid, "title" => $learnergrouptitle ];
}

$selectvalue = isset($data->selectsubgroup) ? $data->selectsubgroup : '';
if (!empty($selectvalue)) {
list($subgroupid, $subgrouptitle) = explode( ":", $selectvalue, 2);
$synctype = 'learnerGroup';
$syncid = $subgroupid;
$syncinfo["subGroup"] = array( "id" => $subgroupid, "title" => $subgrouptitle );
$syncinfo["subGroup"] = [ "id" => $subgroupid, "title" => $subgrouptitle ];
}

if ($data->id) {
// NOTE: no cohort or learner group changes here!!!
if ($data->roleid != $instance->roleid) {
// The sync script can only add roles, for perf reasons it does not modify them.
role_unassign_all(array('contextid'=>$context->id, 'roleid'=>$instance->roleid, 'component'=>'enrol_ilios', 'itemid'=>$instance->id));
role_unassign_all(['contextid' => $context->id, 'roleid' => $instance->roleid, 'component' => 'enrol_ilios', 'itemid' => $instance->id]);
}

$instance->name = $data->name;
Expand All @@ -140,13 +140,13 @@

$DB->update_record('enrol', $instance);
} else {
$enrol->add_instance($course, array('name'=>$data->name, 'status'=>$data->status,
'customchar1'=>$synctype,
'customint1'=>$syncid,
'customtext1'=>json_encode($syncinfo),
'roleid'=>$data->roleid,
'customint2'=>$data->selectusertype,
'customint6'=>$data->customint6));
$enrol->add_instance($course, ['name' => $data->name, 'status' => $data->status,
'customchar1' => $synctype,
'customint1' => $syncid,
'customtext1' => json_encode($syncinfo),
'roleid' => $data->roleid,
'customint2' => $data->selectusertype,
'customint6' => $data->customint6]);
}

$trace = new null_progress_trace();
Expand Down

0 comments on commit 2cb096d

Please sign in to comment.