Fix inactive Browser Use webview attachment on Linux#1010
Conversation
Yo-DDV
left a comment
There was a problem hiding this comment.
Thanks for the patch. I think this still needs one change before it can be treated as fixing the current upstream drift.
The store descriptor added at scripts/patches/core/all-linux/webview/browser-use-attach-recovery/patch.js:17 does not match the upstream DMG that this PR's own Build App Against Upstream DMG job tested. That job passed overall, but its patch summary says linux-browser-use-webview-attach-recovery-store was skipped-optional, and the final acceptance verdict was accepted_with_warnings. So the host half can apply while the store half is still missing, which means the recovery patch is not actually fully restored on the current DMG.
Could you retarget the store descriptor to the real current store chunk and add a regression/report check that catches this case? A green CI job is a bit misleading here because optional patch drift is allowed to pass, but for this PR the skipped store half is the behavior being fixed.
1a8b52b to
283f8a4
Compare
|
Thanks for the update. When this is ready for maintainer review, please remember to mark the pull request as ready for review instead of leaving it in draft. |
ilysenko
left a comment
There was a problem hiding this comment.
Thanks for the update. The ownership change itself matches the reported inactive-conversation failure, and the previous descriptor issue was fixed for DMG 26.707.72221.
The currently supported DMG is now 26.715.21425, however. Against the current DMG, linux-browser-use-webview-attach-recovery is skipped-optional while only linux-browser-use-hidden-host-ownership applies. The descriptor still targets the obsolete combined onboarding chunk, and the new “current assets” regression test reproduces that older layout rather than the current split store/host assets.
Please rebase onto current main, retarget the recovery descriptors and implementation exclusively to the current DMG layout, remove the obsolete combined-bundle path as required by the current-DMG-only policy, update the patch-report regression with current production shapes, and rerun the upstream build. Please also complete the pending full-restart live Browser attachment validation and mark the PR ready for review.
|
I reproduced the current-DMG failure independently and prepared the requested retarget on top of current The current
The commit removes the obsolete combined-bundle descriptor, creates current-only store and host descriptors, updates the host lifecycle fixture to the production shape, and adds a patch-report regression requiring all three descriptors to be Validation completed against DMG SHA-256
Live side-by-side validation also passed: I restarted the isolated app and confirmed that it relaunched cleanly, but the external test task binding did not re-register with that restarted side-by-side instance. I am therefore not claiming the pending full-restart Browser attachment check as complete; that last check still needs to be run from a task actively owned by the restarted instance. After rebasing the PR branch onto current |
Co-authored-by: pinguuss <caiofaheina@gmail.com>
283f8a4 to
8a8057c
Compare
|
Thanks for the update. When this is ready for maintainer review, please remember to mark the pull request as ready for review instead of leaving it in draft. |
Summary
skipped-optionalRoot cause
The Browser Use store was synchronizing correctly, but
HiddenBrowserUseWebviewHostreturnednullwhenever its conversation was not the active route and any Browser panel was open. Browser automation can legitimately target an inactive synthetic conversation while the visible task owns the panel. In that state the hidden host chunk loaded, but no<webview>was mounted, so neitherwill-attach-webviewnordid-attach-webviewfired and the 15-second wait timed out.The current upstream DMG also split the recovery seams across three renderer assets, so the obsolete combined onboarding-bundle descriptor could no longer restore the store and host halves atomically.
Validation
node --test scripts/patch-linux-window-ui.test.js— 380/380 passedbash tests/scripts_smoke.sh— passed26.715.21425build — passed with anaccepted_with_warningsverdict; none of the optional drift entries are Browser recovery descriptorsRemaining gate
The full-restart live Browser attachment validation is still pending. The PR remains draft until a task actively owned by the restarted instance confirms the attachment path end to end.