fix(computer-use): target current availability bundle#1027
Closed
malintha-induwara wants to merge 3 commits into
Closed
fix(computer-use): target current availability bundle#1027malintha-induwara wants to merge 3 commits into
malintha-induwara wants to merge 3 commits into
Conversation
Route the opt-in Computer Use UI patch to the current Electron 42 shared renderer bundle while keeping settings patch drift independent. Remove the obsolete install-flow patch helper and add regression coverage for the current upstream bundle layout.
There was a problem hiding this comment.
Pull request overview
This PR updates the Linux Computer Use UI patch routing to align with the current upstream Electron 42 webview bundle layout, removing the now-obsolete install-flow patch implementation and strengthening regression coverage so settings-bundle drift and install-flow drift remain independently detectable.
Changes:
- Removed the dedicated Computer Use install-flow patch implementation/export and consolidated on the renderer availability patch.
- Updated the Computer Use UI patch descriptors to target the current install-flow bundle naming pattern while keeping the settings bundle separately tracked.
- Added/updated tests to validate current bundle matching and exercise the latest upstream DMG asset layout behavior.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
scripts/patches/impl/computer-use.js |
Removes the obsolete install-flow patch function/export; renderer availability patch continues to handle the required-features object form used by current bundles. |
scripts/patches/core/all-linux/webview/computer-use-ui/patch.js |
Retargets the install-flow descriptor to the current Electron 42 bundle pattern and applies the renderer availability patch for both settings + install-flow bundles. |
scripts/patch-linux-window-ui.test.js |
Updates descriptor matching tests and refreshes extracted-app regression fixtures to the latest upstream bundle name/layout. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+8706
to
+8710
| const { value: result, warnings } = captureWarns(() => | ||
| patchAssetFiles( | ||
| tempRoot, | ||
| installFlowDescriptor.pattern, | ||
| installFlowDescriptor.apply, |
Comment on lines
+29
to
33
| /^app-initial~artifact-tab-content\.electron~app-main~pull-request-route~pull-request-code-rev~.*\.js$/, | ||
| missingDescription: "current Computer Use install flow bundle", | ||
| skipDescription: "Linux Computer Use install flow patch", | ||
| apply: applyLinuxComputerUseInstallFlowPatch, | ||
| apply: applyLinuxComputerUseRendererAvailabilityPatch, | ||
| }), |
malintha-induwara
marked this pull request as draft
July 16, 2026 14:13
malintha-induwara
marked this pull request as ready for review
July 16, 2026 14:15
Author
|
Closing as superseded by #1028, which merged the current Computer Use UI availability fix for the latest upstream DMG layout. Rebasing this branch would preserve older required-features bundle behavior that is no longer current. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
git diff --checknode --test scripts/patch-linux-window-ui.test.jsChecklist
CONTRIBUTING.md, kept the change focused, edited source files rather than generated output, and removed unrelated changes.CODEX.DMGlayout and removes the obsolete fallback implementation and tests.