Fix Linux in-app browser window-open routing#1030
Closed
psypeal wants to merge 1 commit into
Closed
Conversation
Contributor
|
Thanks for contributing. This repository allows a maximum of 1 active pull request per contributor. You currently have 2 open pull requests, so this pull request is being closed automatically. Please finish or close one of your existing pull requests before opening another. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
window.openrequests with Electron'sotherdisposition into the upstream foreground-tab route.Root cause
Stock Linux Electron does not expose the proprietary web-contents adoption path used by the upstream desktop runtime. Target-blank result links can therefore arrive with the
otherdisposition and be denied before the upstream tab message is emitted. A broadwindow_openfallback also incorrectly makes Google results dedicated tabs.This change keeps the upstream route and adoption behavior intact, adds the narrow Linux disposition normalization, and uses Bing's
/ck/aresult redirect as the fallback discriminator when Electron does not provide a reliable opener URL.Scope
This PR contains only window-open behavior and the obsolete navigation-patch cleanup. Linux Browser sidebar user-agent normalization remains isolated in #1022.
Validation
node --test scripts/patch-linux-window-ui.test.js— 406/406 passing.