Fix/pet overlay drag for COSMIC#1056
Conversation
…and handle input shape based on overlay configuration
… improvements and native drag handling for Linux
ilysenko
left a comment
There was a problem hiding this comment.
Thanks for the focused COSMIC pet-overlay work. I found one blocker before this can merge.
This PR removes the existing KWin/KDE Plasma implementation and its regression coverage while the feature manifest and README still advertise kwin: true, KDE Plasma hints, and Plasma drag validation. The final patch no longer defines the KWin qdbus/script helpers or the CODEX_PET_OVERLAY_KWIN runtime override; only swallowed calls to missing KWin helpers remain. That silently regresses the documented Plasma path for pet-overlay users.
Please preserve the existing KWin support and tests while adding the COSMIC/full-window input path, or split any intentional KWin removal into a separate PR with updated feature defaults/docs and a clear rationale.
ilysenko
left a comment
There was a problem hiding this comment.
Approved after restoring the Niri live-drag transport, preserving KWin coverage, and verifying the current head with local and GitHub checks.
Summary
pet-overlayto provide a frameless, transparent mascot window on Linux. In the unlocked mode, transparent space moves the native window while the mascot remains draggable within its view and tray controls remain interactive.lockPosition, and existing Hyprland/Niri behavior.Validation
node --test linux-features/pet-overlay/test.js— 54/54 passing.node --test scripts/patch-linux-window-ui.test.js— 364/364 passing.pet-overlayenabled.