Fix shared app-server socket DMG drift#1062
Merged
ilysenko merged 1 commit intoJul 18, 2026
Merged
Conversation
moxw
marked this pull request as ready for review
July 17, 2026 21:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The current DMG added fields before the SSH transport's
kindmarker and changed the local transport factory from a ternary fallback to anif (websocketUrl)block. The feature descriptor therefore skipped, and enabled-feature acceptance rejected the candidate.User impact
Native bootstrap and updater rebuilds can accept the current DMG when
shared-app-server-socketis enabled. The feature's runtime behavior is unchanged.Validation
node --test linux-features/shared-app-server-socket/test.js— 24 passednode --checkpassed for the feature sources and patched current bundleaccepted_with_warnings;shared-app-server-socketapplied once with no enabled-feature blockersLimitations
The rebuild retains unrelated optional core drift warnings already present for the current DMG.