Skip to content

Fix shared app-server socket DMG drift#1062

Merged
ilysenko merged 1 commit into
ilysenko:mainfrom
moxw:agent/fix-shared-app-server-socket-drift
Jul 18, 2026
Merged

Fix shared app-server socket DMG drift#1062
ilysenko merged 1 commit into
ilysenko:mainfrom
moxw:agent/fix-shared-app-server-socket-drift

Conversation

@moxw

@moxw moxw commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Summary

  • update the shared app-server socket detector for the current upstream SSH WebSocket transport class
  • match the current local transport factory's WebSocket fallback block
  • keep the patch fail-soft, idempotent, and latest-DMG-only
  • add regression coverage that rejects the previous bundle shape

Root cause

The current DMG added fields before the SSH transport's kind marker and changed the local transport factory from a ternary fallback to an if (websocketUrl) block. The feature descriptor therefore skipped, and enabled-feature acceptance rejected the candidate.

User impact

Native bootstrap and updater rebuilds can accept the current DMG when shared-app-server-socket is enabled. The feature's runtime behavior is unchanged.

Validation

  • node --test linux-features/shared-app-server-socket/test.js — 24 passed
  • real current-DMG main bundle — first pass changed, second pass byte-identical, one transport injected
  • node --check passed for the feature sources and patched current bundle
  • current-DMG transactional rebuild — accepted_with_warnings; shared-app-server-socket applied once with no enabled-feature blockers

Limitations

The rebuild retains unrelated optional core drift warnings already present for the current DMG.

@moxw
moxw marked this pull request as ready for review July 17, 2026 21:28

@ilysenko ilysenko left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the current head bd127c0. No blockers found; focused optional feature drift fix with passing checks.

@ilysenko
ilysenko merged commit f126ebe into ilysenko:main Jul 18, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants