Fix Chrome app-server proxy inheritance on Linux#1121
Merged
ilysenko merged 7 commits intoJul 23, 2026
Conversation
ilysenko
requested changes
Jul 22, 2026
ilysenko
left a comment
Owner
There was a problem hiding this comment.
Thanks for the focused fix and regression coverage. I found three blockers before this is safe to merge:
- An executable
native-hostpre-seeded while the cache root was unsafe is retained after permissions are hardened because the marker is trusted without regenerating the file. Please force regeneration after unsafe-cache detection and add a regression case. - Proxy restoration needs to preserve
NO_PROXY/no_proxyand GNOMEignore-hosts, and honor GNOME’s HTTP-to-HTTPS/use-same-proxysemantics. The current default manual GNOME shape can still leave HTTPS direct or proxy bypassed destinations. - The new smoke fixture stages only the x64 host, while the wrapper selects arm64 on ARM64 systems. Please make the fixture architecture-aware or stub
uname.
ilysenko
approved these changes
Jul 23, 2026
ilysenko
left a comment
Owner
There was a problem hiding this comment.
Verified the requested fixes and the final clean, green head.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HTTP_PROXY,HTTPS_PROXY,ALL_PROXY, and their lowercase variants from the systemd user environment without overriding inherited valueslatestextension-host target unchangedChrome starts native messaging hosts outside the desktop launcher environment. On proxied Linux desktops this allowed the side panel to start, but its Codex app-server attempted a direct connection and remained stuck in
Thinking. The generated native-host launcher restores the user-session proxy environment before executing the bundled extension host.This stays separate from the bundled-plugin trust/materialization fix in #1105: it does not bless or rewrite plugin source trees and only changes the manifest target used after the existing cache trust checks pass.
Validation
bash tests/scripts_smoke.shexited 1 after Chrome cache sync because the direct extension-host received no proxy variablesbash tests/scripts_smoke.sh—All script smoke tests passednode --test scripts/patch-linux-window-ui.test.js scripts/lib/linux-features.test.js scripts/patches/descriptor.test.js scripts/patches/runner.test.js linux-features/*/test.js— 1200 passed, 0 failedbash -n install.sh scripts/lib/*.sh launcher/start.sh.template scripts/build-deb.sh scripts/build-rpm.sh scripts/build-pacman.sh scripts/build-appimage.sh tests/scripts_smoke.shnode --check scripts/patches/impl/main-process/browser.jsgit diff --check origin/main...HEAD.deb, Desktop 26.715.71837; Chrome side-panel replies resumed after restart with the native host using the GNOME proxyChecklist
CODEX.DMGand removes obsolete fallback code and tests from the affected area.