fix(frontend): toggle results tabs visibility based on analysis data - #1703
Open
nitin-sharma-20 wants to merge 2 commits into
Open
fix(frontend): toggle results tabs visibility based on analysis data#1703nitin-sharma-20 wants to merge 2 commits into
nitin-sharma-20 wants to merge 2 commits into
Conversation
Author
|
hi @imDarshanGK can you review this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves visual ambiguity between Full Analysis and Explain modes where clicking "Explain" previously showed all 3 result tabs (Explain, Debug, Improve) with an identical appearance to Full Analysis.
Specifically:
renderResults(result, code)infrontend/index.htmlto extract whetherexplanation,debugging, andsuggestionsare present in the analysis result, dynamically hide tab buttons (tab-explain,tab-debug,tab-suggest) when their corresponding data is missing, and switch the active selected tab (targetTab) to the first available/active tab instead of always defaulting to 'explain'.resetResults()infrontend/index.htmlto restore default display styles ('flex') for all three tabs so that they become visible again when the session is cleared.backend/tests/test_frontend_results_tabs_visibility.pyand documented the fix indocs/CHANGELOG.md.Related Issue
Fixes #1700
Type of change
Checklist
mainpytest -vand all tests passfeat/fix/docs/test: short descriptionScreenshots (if frontend change)
Test evidence