Remove bounds checks from color transform hot loop #133
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code isn't vectorized on baseline x86_64 but at least per-block bounds checks in the inner loop are gone.
Assembly:
before: https://rust.godbolt.org/z/f5r1noP51
after: https://rust.godbolt.org/z/1fx9qebvh
If I tell the compiler to target Zen 3, it does vectorize the code, so perhaps this function would be a good target for multiversioning: https://rust.godbolt.org/z/jrnor5vqY
But that's out of scope of this PR.