Expose IPTC metadata for PNG, JPG and Tiff #2611
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds an `iptc_metadata` method (similar to `xmp_metadata` and `exif_metadata`) to the `ImageDecoder` and implements it for PNG and JPG.
This comment was marked as outdated.
This comment was marked as outdated.
1c3t3a
changed the title
1c3t3a
commented
Sep 22, 2025
Comment on lines
+540
to
+545
| /// This method converts a `Value` to a vector of bytes. A `Value` in Tiff can have different | ||
| /// types, e.g. a byte, a short or a float. This method intents to convert all these types to | ||
| /// a vector of bytes (e.g. a u32 can be represented as a [u8; 4]). However, since this is only | ||
| /// intended to parse values stored in XMP, IPTC and EXIF metadata sections, we ignore / return | ||
| /// an error on a few Values that don't make sense in this context (e.g. Value::Ifd). | ||
| fn value_to_bytes(value: Value, bytes: &mut Vec<u8>) -> ImageResult<()> { |
There was a problem hiding this comment.
|
The CI failure seems to be due to a spurious network failure in a setup step. Is there a way to retrigger the run? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds an
iptc_metadatamethod (similar toxmp_metadataandexif_metadata) to theImageDecoderand implements it for PNG and JPG.This is related to #2610. If my research was correct and IPTC metadata only exists in PNG and JPG, then this should fix the issue.