Skip to content

Conversation

@OrangeHoopla
Copy link
Contributor

rand: 0.8.0 -> 0.9.2
nalgebra: 0.33.0 -> 0.34.1
rand_distr: 0.4.0 -> 0.5.1
getrandom: 0.2.0 -> 0.3.4

@OrangeHoopla
Copy link
Contributor Author

This seems to break the test ubuntu / 1.81.0 (beyond what tests are broken on main) is this project trying to keep compatibility with older versions of rust?

@OrangeHoopla
Copy link
Contributor Author

OrangeHoopla commented Oct 29, 2025

@cospectrum I saw after making this PR that you downgraded rand,rand_distr and getrandom. Do you mind if I ask why before this is closed?

@cospectrum
Copy link
Contributor

cospectrum commented Oct 29, 2025

Ubuntu check failed because it’s testing msrv. Try to update rust-version in Cargo.toml.
After that I will merge

@cospectrum
Copy link
Contributor

Regarding the old rustc, I think it’s pragmatic to keep up with the latest versions of image crate and other dependencies, so don’t worry about that

@cospectrum
Copy link
Contributor

cospectrum commented Oct 29, 2025

Ah, also I downgraded rand crates to semver compatible, because it gives more freedom to cargo resolver and tests passed with those versions

@cospectrum
Copy link
Contributor

Following this logic, maybe it would better to update crates like this?
rand: 0.8.0 -> 0.9.0
nalgebra: 0.33.0 -> 0.34.0
rand_distr: 0.4.0 -> 0.5.0
getrandom: 0.2.0 -> 0.3.0

@OrangeHoopla
Copy link
Contributor Author

updated msrv to match the image crate but nalgebra requires 1.87.0 to I left that at version 0.33.0

@cospectrum cospectrum merged commit e738502 into image-rs:main Oct 30, 2025
13 of 19 checks passed
@cospectrum
Copy link
Contributor

Thx for your time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants