- 
                Notifications
    You must be signed in to change notification settings 
- Fork 168
Updating Libs #732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating Libs #732
Conversation
| This seems to break the test ubuntu / 1.81.0 (beyond what tests are broken on main) is this project trying to keep compatibility with older versions of rust? | 
| @cospectrum I saw after making this PR that you downgraded rand,rand_distr and getrandom. Do you mind if I ask why before this is closed? | 
| Ubuntu check failed because it’s testing msrv. Try to update rust-version in Cargo.toml. | 
| Regarding the old rustc, I think it’s pragmatic to keep up with the latest versions of  | 
| Ah, also I downgraded rand crates to semver compatible, because it gives more freedom to cargo resolver and tests passed with those versions | 
| Following this logic, maybe it would better to update crates like this? | 
| updated msrv to match the  | 
| Thx for your time! | 
rand: 0.8.0 -> 0.9.2
nalgebra: 0.33.0 -> 0.34.1
rand_distr: 0.4.0 -> 0.5.1
getrandom: 0.2.0 -> 0.3.4