Skip to content

fix: change pgvecto.rs to VectorChord breaking change #563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: change pgvecto.rs to VectorChord breaking change #563

wants to merge 3 commits into from
+17 −7

Conversation

@topiga
Copy link

@topiga topiga commented May 22, 2025

Immich is migrating off the deprecated pgvecto.rs database extension to its successor VectorChord, which comes with performance improvements in almost all aspects. The repo needs to be updated accordingly.

@ImageGeniusCI
Copy link
Contributor

ImageGeniusCI commented May 22, 2025

I am a bot, here are the test results for this PR:
https://ci-tests.imagegenius.io/immich/v1.133.0-pkg-68694c96-dev-938d080eecfac7aa12dd0d535f449d5d9b3ffd8b-pr-563/index.html
https://ci-tests.imagegenius.io/immich/v1.133.0-pkg-68694c96-dev-938d080eecfac7aa12dd0d535f449d5d9b3ffd8b-pr-563/shellcheck-result.xml

Tag Passed
amd64-v1.133.0-pkg-68694c96-dev-938d080eecfac7aa12dd0d535f449d5d9b3ffd8b-pr-563 ✅
arm64v8-v1.133.0-pkg-68694c96-dev-938d080eecfac7aa12dd0d535f449d5d9b3ffd8b-pr-563 ❌

martabal
martabal requested changes May 22, 2025
View reviewed changes
Copy link
Collaborator

@martabal martabal left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the README.md is automatically generated by the bot, add it to readme-vars.yml instead

@ImageGeniusCI
Copy link
Contributor

ImageGeniusCI commented May 22, 2025

I am a bot, here are the test results for this PR:
https://ci-tests.imagegenius.io/immich/v1.133.0-pkg-68694c96-dev-cd070147e4e69504d1fac9b97679b9b190fa99e7-pr-563/index.html
https://ci-tests.imagegenius.io/immich/v1.133.0-pkg-68694c96-dev-cd070147e4e69504d1fac9b97679b9b190fa99e7-pr-563/shellcheck-result.xml

Tag Passed
amd64-v1.133.0-pkg-68694c96-dev-cd070147e4e69504d1fac9b97679b9b190fa99e7-pr-563 ✅
arm64v8-v1.133.0-pkg-68694c96-dev-cd070147e4e69504d1fac9b97679b9b190fa99e7-pr-563 ❌

@hydazz
Copy link
Member

hydazz commented May 22, 2025

superseded? https://github.com/imagegenius/docker-immich/pull/564/files#diff-45b5fd74ce0dd06c88fd7b6a9bff959f03ab8b593a905f282b94daa5b8c13d52R86

@topiga
Copy link
Author

topiga commented May 23, 2025

superseded? https://github.com/imagegenius/docker-immich/pull/564/files#diff-45b5fd74ce0dd06c88fd7b6a9bff959f03ab8b593a905f282b94daa5b8c13d52R86

Maybe, yes, I saw a similar issue in mine, I thought it was a design change, but apparently a stylesheet problem.

@ImageGeniusCI
Copy link
Contributor

ImageGeniusCI commented May 23, 2025

I am a bot, here are the test results for this PR:
https://ci-tests.imagegenius.io/immich/v1.133.0-pkg-68694c96-dev-b18dceb433dc90b955890acdc40ab7cabf771192-pr-563/index.html
https://ci-tests.imagegenius.io/immich/v1.133.0-pkg-68694c96-dev-b18dceb433dc90b955890acdc40ab7cabf771192-pr-563/shellcheck-result.xml

Tag Passed
amd64-v1.133.0-pkg-68694c96-dev-b18dceb433dc90b955890acdc40ab7cabf771192-pr-563 ✅
arm64v8-v1.133.0-pkg-68694c96-dev-b18dceb433dc90b955890acdc40ab7cabf771192-pr-563 ❌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@martabal martabal martabal requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@topiga @ImageGeniusCI @hydazz @martabal