Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sites.yml #142

Closed
wants to merge 0 commits into from
Closed

Update sites.yml #142

wants to merge 0 commits into from

Conversation

EdenTamrat
Copy link
Contributor

Hello, I am looking add my update site onto the sites.yml list.

sites.yml Outdated
description: >-
A customizable segmentation tool for fluorescence cell microscopy
analysis used to separate clustered/touching nuclei. For more information-
https://github.com/EdenTamrat/imagej.github.io/blob/1069c0beda8e4f0d5bd70e055b5a294446efca6b/_pages/plugins/Nscale-segmentation.md
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This URL should be https://imagej.net/plugins/Nscale-segmentation, and it should be made into a hyperlink with Markdown syntax.

@ctrueden
Copy link
Member

Thanks @EdenTamrat. I will fix my comment above post-merge, so don't worry about fixing it yourself. 😄

@ctrueden
Copy link
Member

Actually... before I merge this: @EdenTamrat I noticed that the name of the update site is Nscale_segmentaion rather than Nscale-segmentation. Shall we rename the update site to fix this typo, before adding it to the advertised list? Or is that spelling intentional?

@EdenTamrat
Copy link
Contributor Author

Hello, thank you for your comments.
The typo was unintentional; I meant to write Nscale_segmentation like you mentioned.
I would like to rename my update site to fix the error, if its possible.

@hinerm
Copy link
Member

hinerm commented Feb 14, 2024

@EdenTamrat I renamed the update site and then updated your PR. For reasons I don't understand I was able to update your PR once but it updated to the current main instead of the corrected PR. So I just pushed the changes. Apologies for blowing away your PR. If you need anything else though please let me know.

@EdenTamrat
Copy link
Contributor Author

Thanks a lot!

@ctrueden
Copy link
Member

Thanks @hinerm for dealing with this, and sorry @EdenTamrat for dropping the ball on it for so long. Please let us know if you encounter any issues with using the update site!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants