-
Notifications
You must be signed in to change notification settings - Fork 23
Piyush/sdk overhaul #133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
imagekitio
merged 58 commits into
imagekit-developer:master
from
piyushryn:piyush/sdk-overhaul
Jan 13, 2026
Merged
Piyush/sdk overhaul #133
Changes from 37 commits
Commits
Show all changes
58 commits
Select commit
Hold shift + click to select a range
7e72fb5
Remove old files and update .gitignore to include new patterns for lo…
piyushryn acb70a5
Initialize Angular workspace with ImageKit SDK, including components …
piyushryn 4e213d3
Refactor upload method in ImageKitService to use a more specific type…
piyushryn ee70093
Add Apache License and update README for Angular SDK
piyushryn 98d0bcb
Add passthrough attribute support in IKImage and IKVideo components
piyushryn 79447a7
Enhance AppComponent to include UploadTestComponent and manage active…
piyushryn c22fb71
Update package configuration and TypeScript settings for improved bui…
piyushryn 6c7abe0
Update package.json and README for build process and configuration de…
piyushryn a0325be
Refactor IKImage and IKVideo components to utilize utility functions …
piyushryn 5ec2bb4
Remove features section from README.md for clarity and to streamline …
piyushryn c46befc
Update README.md to change license from MIT to Apache 2.0
piyushryn 88d30ae
chore: multiple changes
piyushryn ea79e34
chore: add CHANGELOG and CodeQL workflow
piyushryn 8f2eb47
chore: update testing setup and component configurations
piyushryn 09134c2
chore: update TypeScript imports and Playwright configuration
piyushryn 40a8811
fix: correct transformation string regex in E2E tests for image URL v…
piyushryn c051198
chore: update Playwright testing setup in CI workflow
piyushryn efd08ce
chore: enhance CI workflow with SDK build verification and update Pla…
piyushryn 7803a2a
chore: update TypeScript configuration and refine Playwright testing …
piyushryn 3203bec
chore: update CI workflows for SDK build and testing
piyushryn d459f55
chore: remove deprecated Node CI workflow and update publish workflow…
piyushryn 8f4608c
fix: update E2E test to validate image transformation query parameter
piyushryn c6fd5fd
refactor: remove redundant URL construction validation tests from E2E…
piyushryn e08125e
Add imagekit angular to tsconfig
SwarnimDoegar 7bf36c4
Merge branch 'piyush/sdk-overhaul' of https://github.com/piyushryn/im…
SwarnimDoegar fe00eb4
Add new test-app with SSR support and tests for ssr and csr
SwarnimDoegar 49f354e
Use node 20 in GH workflows
SwarnimDoegar 51dfb8c
Fix playwright run
SwarnimDoegar 4bb73a2
Fix playwright snapshot creation template
SwarnimDoegar 6d1331d
Run playwright browser install in pubslish job
SwarnimDoegar a3947c0
Update README and package configurations for Angular 14 compatibility
piyushryn 9ec8593
feat: add Transformations type to public API and update IKVideoProps …
piyushryn 895f859
refactor: simplify Transformations type definition in index.ts
piyushryn 88196ed
chore: remove CUSTOM_ELEMENTS_SCHEMA from ImageKitModule
piyushryn 042cec9
chore: downgrade Angular dependencies to version 15 and update relate…
piyushryn dec22e4
chore: update version to 6.0.3 and remove ImageKitModule support
piyushryn 8d70888
chore: downgrade Angular peer dependencies to support versions up to …
piyushryn 84f4d84
refactor: update attribute bindings in IKImageComponent and IKVideoCo…
piyushryn a9cba57
refactor: simplify transformation handling in IKVideoComponent and im…
piyushryn 5ca6038
refactor: remove publicKey and authenticationEndpoint from ImageKit c…
piyushryn 65d234a
chore: add package-lock.json to .gitignore for test-app to prevent un…
piyushryn 779ff3d
refactor: remove ImageKitService from public API and update style pro…
piyushryn 4ac66ec
refactor: rename IKImageComponent and IKVideoComponent to Image and V…
piyushryn 4b2f041
chore: change npm command from ci to install in e2e workflow for test…
piyushryn e3659fe
refactor: remove redundant ik-image components from app.html to strea…
piyushryn 48e3a77
Add Image and Video directive to the SDK
SwarnimDoegar 970e9c3
Add image and video directive examples in test-app
SwarnimDoegar 335e314
Get rid of e2e test flakiness
SwarnimDoegar c73e921
Remove image and video components from SDK
SwarnimDoegar 4f754c6
Finalized directive approach
SwarnimDoegar e8c4e74
Update test-app to use directives
SwarnimDoegar 12c16d1
Use lazy loadig by default for images
SwarnimDoegar b71d05d
Fix test:e2e snapshots
SwarnimDoegar ffb543f
Get rid of onDestroy from directives
SwarnimDoegar 0deefec
Remove height input from image directive
SwarnimDoegar 4b961bf
Do not add sizes attr to img when responsive is false
SwarnimDoegar fbf65f5
Add more attributes to the test app elements
SwarnimDoegar 71a98a4
Fix minor bugs
SwarnimDoegar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,81 @@ | ||
| # This is a test workflow for testing the tests | ||
| name: E2E Tests | ||
|
|
||
| on: | ||
| push: | ||
| branches: ['*'] | ||
| pull_request: | ||
| branches: ['*'] | ||
|
|
||
| jobs: | ||
| playwright-run: | ||
| runs-on: ubuntu-latest | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| project: ['Desktop Chrome'] | ||
|
|
||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Setup Node.js | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: '20' | ||
| cache: 'npm' | ||
|
|
||
| - name: Install dependencies | ||
| run: npm ci | ||
|
|
||
| - name: Build SDK and pack | ||
| run: npm run pack | ||
|
|
||
| - name: Verify SDK build | ||
| run: | | ||
| if [ ! -d "dist/imagekit-angular" ]; then | ||
| echo "Error: SDK build directory not found" | ||
| exit 1 | ||
| fi | ||
| echo "✓ SDK built successfully" | ||
|
|
||
| - name: Install test app dependencies | ||
| working-directory: ./test-app | ||
| run: npm ci | ||
| - name: Install SDK | ||
| working-directory: ./test-app | ||
| run: npm install ../dist/imagekit-angular/imagekit-angular-*.tgz --no-save | ||
| # Note: Playwright browsers are installed via postinstall script | ||
|
|
||
| - name: Install browsers for Playwright | ||
| working-directory: ./test-app | ||
| run: npx playwright install --with-deps | ||
|
|
||
| - name: Run Playwright tests | ||
| working-directory: ./test-app | ||
| run: npm run test:e2e | ||
|
|
||
| - name: Upload test results on failure | ||
| if: failure() | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: playwright-results-${{ matrix.project }} | ||
| path: test-app/test-results/ | ||
| if-no-files-found: ignore | ||
|
|
||
| - name: Upload Playwright report | ||
| if: always() | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: playwright-report-${{ matrix.project }} | ||
| path: test-app/playwright-report/ | ||
| retention-days: 30 | ||
| if-no-files-found: ignore | ||
|
|
||
| - name: Generate test report | ||
| if: always() | ||
| run: | | ||
| echo "## Test Results - ${{ matrix.project }}" >> $GITHUB_STEP_SUMMARY | ||
| echo "Project: ${{ matrix.project }}" >> $GITHUB_STEP_SUMMARY | ||
|
|
||
|
|
This file was deleted.
Oops, something went wrong.
|
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| name: Publish | ||
|
|
||
| on: | ||
| release: | ||
| types: [published] | ||
|
|
||
| jobs: | ||
| build: | ||
| runs-on: ubuntu-latest | ||
|
|
||
| strategy: | ||
| matrix: | ||
| node-version: [20.x] | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v1 | ||
| - name: Use Node.js ${{ matrix.node-version }} | ||
| uses: actions/setup-node@v1 | ||
| with: | ||
| node-version: ${{ matrix.node-version }} | ||
| - name: Build and Test | ||
| run: | | ||
| npm install | ||
| npm run build | ||
| npm pack | ||
| cd test-app | ||
| npm install | ||
| npm install ../dist/imagekit-angular/imagekit-angular-*.tgz --no-save | ||
| npx playwright install --with-deps | ||
| npm run test:e2e | ||
| env: | ||
| CI: true | ||
|
|
||
|
|
||
| publish: | ||
| needs: build | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v1 | ||
| - uses: actions/setup-node@v1 | ||
| with: | ||
| node-version: 20 | ||
| registry-url: https://registry.npmjs.org/ | ||
| - name: NPM Publish | ||
| run: | | ||
| npm install | ||
| npm run build | ||
| npm config set //registry.npmjs.org/:_authToken=$NODE_AUTH_TOKEN | ||
| # print the NPM user name for validation | ||
| npm whoami | ||
| VERSION=$(node -p "require('./projects/imagekit-angular/package.json').version" ) | ||
| # Only publish stable versions to the latest tag | ||
| if [[ "$VERSION" =~ ^[^-]+$ ]]; then | ||
| NPM_TAG="latest" | ||
| else | ||
| NPM_TAG="beta" | ||
| fi | ||
| echo "Publishing $VERSION with $NPM_TAG tag." | ||
| npm publish --tag $NPM_TAG --access public | ||
| env: | ||
| NODE_AUTH_TOKEN: ${{secrets.npm_token}} | ||
| CI: true |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,42 +1,67 @@ | ||
| # See http://help.github.com/ignore-files/ for more about ignoring files. | ||
|
|
||
| # compiled output | ||
| # Compiled output | ||
| /dist | ||
| /tmp | ||
| /out-tsc | ||
| /bazel-out | ||
|
|
||
| # dependencies | ||
| node_modules | ||
| # Node | ||
| /node_modules | ||
| /test-app/node_modules | ||
|
|
||
| npm-debug.log | ||
| yarn-error.log | ||
|
|
||
| # IDEs and editors | ||
| /.idea | ||
| .idea/ | ||
| .project | ||
| .classpath | ||
| .c9/ | ||
| *.launch | ||
| .settings/ | ||
| *.sublime-workspace | ||
|
|
||
| # IDE - VSCode | ||
| # Visual Studio Code | ||
| .vscode/* | ||
| !.vscode/settings.json | ||
| !.vscode/tasks.json | ||
| !.vscode/launch.json | ||
| !.vscode/extensions.json | ||
| .history/* | ||
|
|
||
| # misc | ||
| /.sass-cache | ||
| # Miscellaneous | ||
| /.angular/cache | ||
| /test-app/.angular/cache | ||
| .sass-cache/ | ||
| /connect.lock | ||
| /coverage | ||
| /libpeerconnection.log | ||
| npm-debug.log | ||
| testem.log | ||
| /typings | ||
|
|
||
| # e2e | ||
| /e2e/*.js | ||
| /e2e/*.map | ||
|
|
||
| # System Files | ||
| # System files | ||
| .DS_Store | ||
| Thumbs.db | ||
|
|
||
| # Playwright | ||
| /test-app/test-results/ | ||
| /test-app/playwright-report/ | ||
| /test-app/playwright/.cache/ | ||
|
|
||
| # Logs | ||
| *.log | ||
| logs/ | ||
|
|
||
| # Build artifacts | ||
| *.tsbuildinfo | ||
| *.map | ||
|
|
||
| # Test coverage | ||
| coverage/ | ||
| .nyc_output/ | ||
|
|
||
| # Environment files | ||
| .env | ||
| .env.local | ||
| .env.*.local |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We would need this workflow.