Add option to keep metadata #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sindresorhus
reviewed
Mar 5, 2021
| '-clobber', | ||
| '-o', | ||
| options.optimizationLevel, | ||
| '-out', | ||
| execBuffer.output | ||
| ]; | ||
|
|
||
| if (options.strip) { | ||
| arguments_.unshift('all'); | ||
| arguments_.unshift('-strip'); |
There was a problem hiding this comment.
Just use .push. And one call is enough.
sindresorhus
reviewed
Mar 5, 2021
| @@ -93,6 +93,13 @@ Default: `true` | |||
|
|
|||
| A reasonable amount of effort will be spent to try to recover as much data as possible of a broken image, but the success cannot generally be guaranteed. | |||
|
|
|||
| ##### strip | |||
There was a problem hiding this comment.
Suggested change
| ##### strip | |
| ##### stripMetadata |
There was a problem hiding this comment.
but wouldn't that strip metadata? Or would that be too simple
There was a problem hiding this comment.
I'm not sure what you're asking. I'm saying the option should be named better as it only strips metadata.
|
Hey folks, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the option to preserve the image metadata. More explanation https://manpages.debian.org/stretch/optipng/optipng.1.en.html