Open
Conversation
CodSpeed Performance ReportMerging #222 will not alter performanceComparing Summary
|
Collaborator
|
This is great, thanks, @tlambert03! As I mentioned on Zulip, https://github.com/ome/bioformats/blob/bc1fcddd5329d900853d55c6f8378e9235a26a53/components/formats-api/src/loci/formats/Modulo.java#L39 is probably the best definition of truth for the moment. But if you have any other questions, @jburel, @dgault, @sbesson, and @melissalinkert can hopefully help us out. |
Collaborator
|
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #222 +/- ##
==========================================
- Coverage 86.75% 79.55% -7.20%
==========================================
Files 24 25 +1
Lines 1200 1252 +52
==========================================
- Hits 1041 996 -45
- Misses 159 256 +97 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@joshmoore, here's the beginning of a modulo type
as you can see, the namespaces are still a bit messed up... but it's a start