Gpushift dev #1
Open
Gpushift dev #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boykovdn
commented
Feb 17, 2021
boykovdn
commented
- Basic clustering step
- sklearn-like interface
imagirom
requested changes
Feb 17, 2021
|
|
||
| def predict(self, X): | ||
| r""" | ||
| Predict cluster belonging based on which cluster center is the closest. |
gpushift/sklearn/meanshift.py
Outdated
| # spherical = self._get_distance_metric('spherical') | ||
| # | ||
| # composite = lambda x,y : euclidean(x,y)**2 + spherical(x,y) | ||
| # |
There was a problem hiding this comment.
If this block is no longer needed (as you have implemented it differently above), I would prefer to delete it. Same for the other commented blocks above.
gpushift/sklearn/meanshift.py
Outdated
|
|
||
| self.cluster_centers_ = None | ||
|
|
||
| self.meanshift_step = MeanShiftStep(bandwidth=bandwidth, kernel=kernel, use_keops=use_keops) |
There was a problem hiding this comment.
Was it your intention to not pass the distance metric here? I thought not only the final clustering but also every MS step should use the chosen metric.
Comment on lines
+25
to
+27
| :param distance_metric: callable or None | ||
| If None, uses standard Euclidean distances. For special applications, | ||
| the passing of a custom distance function is allowed. |
There was a problem hiding this comment.
I think it would be good to add the required signature of distance metric if it is a callable, including the shapes of the input tensors, to the docstring.
|
Reminder to also add an example using the new interface (I will do that) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.